Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Do Not Install System Files by Default #2848

Merged
merged 2 commits into from Aug 2, 2019

Conversation

@sanssecours
Copy link
Member

commented Aug 2, 2019

It would be great, if we could include this PR in the next release. This way issue #2835 should be resolved pretty quickly, after we update the Homebrew formula for Elektra 0.9.

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

Ok, I'll add it. The only sys files we have is GI files (which are obsolete) and the shell completions (which do not work well, except of fish).

sanssecours added some commits Jul 31, 2019

Build: Do not install system files by default
This commit resolves issue #2835.
Cirrus: Install system files in FreeBSD build jobs
Since we should check, if installing system files works correctly, we
enable the option `INSTALL_SYSTEM_FILES` in our FreeBSD build jobs
again.

@sanssecours sanssecours force-pushed the sanssecours: branch from eebd9ba to 3038e0d Aug 2, 2019

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

Seems like we also need to fix debian/control before we can merge this. I did it in 6c3a23d

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

jenkins build libelektra please

@markus2330 markus2330 merged commit d157e41 into ElektraInitiative:master Aug 2, 2019

12 of 14 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
bsd FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
bsd FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+64.5%) to 64.597%
Details
linux Task Summary
Details
mac Task Summary
Details
mac ASAN_OPTIONS:detect_leaks=1 BINDINGS:cpp ENABLE_ASAN:ON TOOLS:kdb Task Summary
Details
mac BUILD_FULL:ON BUILD_SHARED:OFF Task Summary
Details
mac KDB_DB_FILE:default.mmap KDB_DB_INIT:elektra.mmap KDB_DEFAULT_STORAGE:mmapstorage Task Summary
Details
restyled No differences
Details
@markus2330

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

Thank you!

@sanssecours sanssecours deleted the sanssecours:🏗 branch Aug 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.