Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for gopts #2864

Merged
merged 3 commits into from Aug 9, 2019

Conversation

@kodebach
Copy link
Contributor

commented Aug 5, 2019

Small fixes for gopts, as discussed in #2853 and #2856.

Basics

  • Short descriptions should be in the release notes (added as entry in
    doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add something to the the release notes.
  • Longer descriptions should be in documentation or in design decisions.
  • Describe details of how you changed the code in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, should be in the commit messages.

Checklist

  • I added unit tests
  • I ran all tests locally and everything went fine
  • affected documentation is fixed
  • I added code comments, logging, and assertions (see Coding Guidelines)
  • meta data is updated (e.g. README.md of plugins and METADATA.ini)

Review

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

Thank you for creating this PR!

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

The invalid link should be fixed in 542c49f

@kodebach kodebach force-pushed the kodebach:fixes branch from 436c4d0 to f44080b Aug 9, 2019

@kodebach kodebach requested a review from markus2330 Aug 9, 2019

@markus2330 markus2330 merged commit 7bb8977 into ElektraInitiative:master Aug 9, 2019

11 of 13 checks passed

LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
bsd FreeBSD:freebsd-11-2-release-amd64 Task Summary
Details
bsd FreeBSD:freebsd-12-0-release-amd64 Task Summary
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linux Task Summary
Details
mac Task Summary
Details
mac ASAN_OPTIONS:detect_leaks=1 BINDINGS:cpp ENABLE_ASAN:ON TOOLS:kdb Task Summary
Details
mac BUILD_FULL:ON BUILD_SHARED:OFF Task Summary
Details
mac KDB_DB_FILE:default.mmap KDB_DB_INIT:elektra.mmap KDB_DEFAULT_STORAGE:mmapstorage Task Summary
Details
restyled No differences
Details
@markus2330

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

❇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.