Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename keyIsDirectBelow to keyIsDirectlyBelow #2988

Conversation

@PhilippGackstatter
Copy link
Contributor

commented Sep 20, 2019

This renames keyIsDirectBelow to keyIsDirectlyBelow as proposed in #2730 and #2979.

So this takes care of the bindings as well. For at least CPP, Java, Haskell and Rust this is a breaking change.

Basics

Check relevant points but please do not remove entries.
Do not describe the purpose of this PR in the PR description but:

  • Short descriptions should be in the release notes (added as entry in
    doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add something to the the release notes.
  • Longer descriptions should be in documentation or in design decisions.
  • Describe details of how you changed the code in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, should be in the commit messages.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests for my code
  • I fixed all affected documentation
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in THIRD-PARTY-LICENSES

Review

Reviewers will usually check the following:

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if the build server is happy and also you
    say that everything is ready to be merged.
@markus2330

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

Thank you for creating this PR!

@markus2330

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2019

The build server is happy now. Unfortunately, there is now a merge conflict. Can you please rebase?

@PhilippGackstatter PhilippGackstatter force-pushed the PhilippGackstatter:rename_keyisdirectbelow branch from dbd9de0 to be5381a Oct 2, 2019
@markus2330

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2019

Something went wrong here, the file "src/bindings/haskell/src/Elektra/Key.chs" was added (but it should stay removed).

@PhilippGackstatter

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

jenkins build libelektra please

2 similar comments
@PhilippGackstatter

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2019

jenkins build libelektra please

@PhilippGackstatter

This comment has been minimized.

Copy link
Contributor Author

commented Oct 6, 2019

jenkins build libelektra please

@markus2330 markus2330 merged commit dd4daf1 into ElektraInitiative:master Oct 6, 2019
11 of 13 checks passed
11 of 13 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
restyled No differences
Details
🍎 Clang Task Summary
Details
🍎 Clang ASAN Task Summary
Details
🍎 FULL Task Summary
Details
🍎 MMap Task Summary
Details
🔗 Check Task Summary
Details
😈 FreeBSD 11 Task Summary
Details
😈 FreeBSD 12 Task Summary
Details
@markus2330

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2019

Thank you, you have really great progress!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.