Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keyRel and keyRel2 #3038

Merged

Conversation

@PhilippGackstatter
Copy link
Contributor

commented Oct 6, 2019

fixes #3034

Removes keyRel from the jna binding as well. The others do not seem to be affected.

Basics

Check relevant points but please do not remove entries.
Do not describe the purpose of this PR in the PR description but:

  • Short descriptions should be in the release notes (added as entry in
    doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add something to the the release notes.
  • Longer descriptions should be in documentation or in design decisions.
  • Describe details of how you changed the code in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, should be in the commit messages.

Checklist

Check relevant points but please do not remove entries.
For docu fixes, spell checking, and similar none of these points below
need to be checked.

  • I added unit tests for my code
  • I fixed all affected documentation
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in THIRD-PARTY-LICENSES

Review

Reviewers will usually check the following:

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if the build server is happy and also you
    say that everything is ready to be merged.
@PhilippGackstatter PhilippGackstatter referenced this pull request Oct 6, 2019
@markus2330

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2019

Thank you for creating this PR!

@PhilippGackstatter PhilippGackstatter force-pushed the PhilippGackstatter:remove_keyrel branch from 4b02810 to 9de4226 Oct 7, 2019
@@ -46,7 +46,7 @@ int elektraNoresolverGet (Plugin * handle ELEKTRA_UNUSED, KeySet * returned ELEK

Key * root = keyNew ("system/elektra/modules/" ELEKTRA_PLUGIN_NAME, KEY_END);

if (keyRel (root, parentKey) >= 0)
if (keyCmp (root, parentKey) == 0 || keyIsBelow (root, parentKey) == 1)

This comment has been minimized.

Copy link
@markus2330

markus2330 Oct 9, 2019

Contributor

Why not keyIsBelowOrSame? Or we remove keyIsBelowOrSame because it is hardly used?

This comment has been minimized.

Copy link
@PhilippGackstatter

PhilippGackstatter Oct 9, 2019

Author Contributor

I did not realize this function existed. It's even part of the public api, but I always checked the documentation and since it's not displayed there, I didn't know about it.

Or we remove keyIsBelowOrSame because it is hardly used?

If we want to provide the minimal amount of necessary functions for 1.0, then removing it is not a bad idea.

This comment has been minimized.

Copy link
@markus2330

markus2330 Oct 10, 2019

Contributor

Weird, can you find out why it is not in the documentation? (Or report an issue about that.)

If we want to provide the minimal amount of necessary functions for 1.0, then removing it is not a bad idea.

Yes, the API should be minimal as extending is easy but removal is not possible after 1.0 release.

This comment has been minimized.

Copy link
@markus2330

markus2330 Oct 10, 2019

Contributor

(Or better report the issue first, if we remove it, we do not need to fix the docu.)

@markus2330 markus2330 merged commit 91e5808 into ElektraInitiative:master Oct 9, 2019
10 of 12 checks passed
10 of 12 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
🍎 Clang Task Summary
Details
🍎 Clang ASAN Task Summary
Details
🍎 FULL Task Summary
Details
🍎 MMap Task Summary
Details
🔗 Check Task Summary
Details
😈 FreeBSD 11 Task Summary
Details
😈 FreeBSD 12 Task Summary
Details
@markus2330

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

Thank you, great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.