Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: Reformat Code With cmake-format 0.6.3 #3337

Merged
merged 4 commits into from Dec 16, 2019

Conversation

@sanssecours
Copy link
Member

sanssecours commented Dec 14, 2019

No description provided.

sanssecours added 4 commits Dec 12, 2019
@mpranj

This comment has been minimized.

Copy link
Member

mpranj commented Dec 16, 2019

Thank you! Do you want this in immediately or shortly before the next release?

@sanssecours

This comment has been minimized.

Copy link
Member Author

sanssecours commented Dec 16, 2019

Do you want this in immediately or shortly before the next release?

I would prefer we merge this as soon as possible. Since the formatting changes between version 0.6 and version 0.6.3 are relatively minor – only six CMake files were changed – I do not think that should be that big of a problem. Of course, If there are bigger pull requests that are “ready to merge” soon, I have no problem whatsoever if you merge those first.

@mpranj mpranj merged commit 3999d92 into ElektraInitiative:master Dec 16, 2019
17 checks passed
17 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on PR-3337 at 62.081%
Details
restyled No differences
Details
🍎 Clang Task Summary
Details
🍎 Clang ASAN Task Summary
Details
🍎 FULL Task Summary
Details
🍎 MMap Task Summary
Details
🐧 Fedora Task Summary
Details
📚 Check Task Summary
Details
🔗 Check Task Summary
Details
😈 ASAN Task Summary
Details
😈 FreeBSD 11 Task Summary
Details
😈 FreeBSD 12 Task Summary
Details
@mpranj

This comment has been minimized.

Copy link
Member

mpranj commented Dec 16, 2019

Thank you so much for maintaining it!

I agree that it should not be a huge problem. I just asked because that's how it was previously done.

@sanssecours sanssecours deleted the sanssecours:🦚 branch Dec 16, 2019
@markus2330

This comment has been minimized.

Copy link
Contributor

markus2330 commented Jan 14, 2020

We only updated tools shortly before releases as the constant updating of the tools (or the docker image to reformat) is a quite big barrier for Elektra developers (at least it was for me, as I work on several computers). Furthermore, requiring people to rebase PRs just because of reformatting is not so nice. After releases, everything needs to be rebased anyway, so there is no issue then.

You do not need to follow this advice. As I currently do not change code, it doesn't affect me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.