Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: enables SSR rendering and compatibility #13018

Closed
wants to merge 1 commit into from

Conversation

@boyangwang
Copy link

boyangwang commented Oct 11, 2018

This commit enables rendering of vnode and DOM during SSR
Changes are:

	modified:   examples/play/index.vue
	modified:   packages/table/src/table-body.js
	modified:   packages/table/src/table-column.js
	modified:   packages/table/src/table-store.js
	modified:   packages/table/src/table.vue

packages/table/src/table-body.js
give colspan rowspan default value of 1

packages/table/src/table-column.js
add insertColumn action to created hook

packages/table/src/table-store.js
updateColumns() is a safe operation, do it even if $ready===false

packages/table/src/table.vue
do updateColumns() in created hook

examples/play/index.vue
contains an example. Not intended to commit, for testing & verification purpose

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.
This commit enables rendering of vnode and DOM during SSR
Changes are:

give colspan rowspan default value of 1

add insertColumn operation to created hook

updateColumns() is a safe operation, do it even if $ready===false

do updateColumns() in created hook

contains an example. Not intended to commit, for testing & verification purpose
@element-bot

This comment has been minimized.

Copy link
Collaborator

element-bot commented Oct 11, 2018

Deploy preview for element ready!

Built with commit 14ecbcc

https://deploy-preview-13018--element.netlify.com

@eeeeeeeason

This comment has been minimized.

Copy link
Contributor

eeeeeeeason commented Jun 11, 2019

我该怎么拿到你这次提交。能正常获取store里的信息到window.INITIAL_STATE,我特喵的el-table里的数据是空的。

@island205 island205 force-pushed the ElemeFE:dev branch from 3b99c46 to 1afce45 Jun 21, 2019
@@ -1,8 +1,88 @@
<template>
<div style="margin: 20px;">
<el-table

This comment has been minimized.

Copy link
@island205

island205 Nov 5, 2019

Collaborator

don't commit these testing codes.

@island205 island205 requested a review from ziyoung Nov 5, 2019
@island205 island205 closed this Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.