From b90f8f9e863c901ad5e86495ade2f301d9fb04a9 Mon Sep 17 00:00:00 2001 From: Riccardo Casatta Date: Fri, 13 Oct 2023 08:42:17 +0200 Subject: [PATCH 1/4] CI: pin byteorder to 1.4.3 --- contrib/test.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/test.sh b/contrib/test.sh index 8a006608..ac8dff7a 100755 --- a/contrib/test.sh +++ b/contrib/test.sh @@ -14,6 +14,7 @@ if cargo --version | grep "1\.58"; then cargo update -p quote --precise 1.0.30 cargo update -p proc-macro2 --precise 1.0.63 cargo update -p serde_test --precise 1.0.152 + cargo update -p byteorder --precise 1.4.3 fi # Format if told to From dab0108faac9532d20540e420962daa33b72be56 Mon Sep 17 00:00:00 2001 From: Riccardo Casatta Date: Fri, 13 Oct 2023 08:53:13 +0200 Subject: [PATCH 2/4] fuzz: pin byteorder to 1.4.3 --- fuzz/fuzz.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fuzz/fuzz.sh b/fuzz/fuzz.sh index 5fc65ae6..3d940c02 100755 --- a/fuzz/fuzz.sh +++ b/fuzz/fuzz.sh @@ -18,6 +18,8 @@ fi cargo --version rustc --version +cargo update -p byteorder --precise 1.4.3 + # Testing cargo install --force honggfuzz --no-default-features for targetFile in $targetFiles; do From 275da64284881b1b45647ce0795fbeb27aaf7355 Mon Sep 17 00:00:00 2001 From: Riccardo Casatta Date: Fri, 13 Oct 2023 09:35:45 +0200 Subject: [PATCH 3/4] ci: remove old MSRV pinnings --- contrib/test.sh | 5 ----- 1 file changed, 5 deletions(-) diff --git a/contrib/test.sh b/contrib/test.sh index ac8dff7a..16d7f96f 100755 --- a/contrib/test.sh +++ b/contrib/test.sh @@ -9,11 +9,6 @@ rustc --version # Pin dependencies required to build with Rust 1.58 if cargo --version | grep "1\.58"; then - cargo update -p serde_json --precise 1.0.99 - cargo update -p serde --precise 1.0.156 - cargo update -p quote --precise 1.0.30 - cargo update -p proc-macro2 --precise 1.0.63 - cargo update -p serde_test --precise 1.0.152 cargo update -p byteorder --precise 1.4.3 fi From 9afa79ce696fd019ab07afe2f4fed36d816dbdf1 Mon Sep 17 00:00:00 2001 From: Riccardo Casatta Date: Fri, 13 Oct 2023 09:39:05 +0200 Subject: [PATCH 4/4] readme: update MSRV pinning instructions --- README.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 3ffa4c12..f84d6f4e 100644 --- a/README.md +++ b/README.md @@ -47,9 +47,12 @@ Some dependencies do not play nicely with our MSRV, if you are running the tests you may need to pin as follows: ``` -cargo update -p serde --precise 1.0.156 +cargo update -p byteorder --precise 1.4.3 ``` +Note this list could sometimes be not exhaustive because not enforced by CI. +If you have any issues check the script executed in CI: `contrib/test.sh` + ## Contributing Contributions are generally welcome. If you intend to make larger changes please discuss them in an issue before PRing them to avoid duplicate work and