Skip to content

Conversation

@RCasatta
Copy link
Collaborator

@RCasatta RCasatta commented May 8, 2024

No description provided.

Copy link
Member

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 747ebe0

CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
# 0.3.1 - May 10, 2024

- [Fixed](https://github.com/ElementsProject/elements-miniscript/pull/81) Elip151 hash calculation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ELIP is an acronym

Suggested change
- [Fixed](https://github.com/ElementsProject/elements-miniscript/pull/81) Elip151 hash calculation
- [Fixed](https://github.com/ElementsProject/elements-miniscript/pull/81) ELIP-151 hash calculation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, thanks.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 41d0732 yeah, I think a minor rev is ok because this is a bugfix, even though arguably it is a breaking change

@apoelstra apoelstra merged commit 3abd2fa into ElementsProject:master May 10, 2024
@apoelstra
Copy link
Member

Tagged and published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants