Github-Pull: #5465
Rebased-From: 422f873 d546191 d7db4b6 e27d7cb

Github-Pull: #5461
Rebased-From: aa768f1

Rebased-From: 164a45f
Github-Pull: #5471

Bump version but keep CLIENT_VERSION_IS_RELEASE at false as this is not
a release yet.

Rebased-From: 84857e8
Github-Pull: #5437

Previously transactions were only tested again the
STANDARD_SCRIPT_VERIFY_FLAGS prior to mempool acceptance, so any bugs in
those flags that allowed actually-invalid transactions to pass would
result in allowing invalid transactions into the mempool. Fortunately
there is a second check in CreateNewBlock() that would prevent those
transactions from being mined, resulting in an invalid block, however
this could still be exploited as a DoS attack.

Rebased-From: 7c041b3

…ional

Rebased-From: 4bc95c4

Rebased-From: 3497022
Github-Pull: #5459

Previously the minRelayTxFee was only enforced on user specified values.

It was possible for smartfee to produce a fee below minRelayTxFee which
 would just result in the transaction getting stuck because it can't be
 relayed.

This also introduces a maxtxfee option which sets an absolute maximum
 for any fee created by the wallet, with an intention of increasing
 user confidence that the automatic fees won't burn them. This was
 frequently a concern even before smartfees.

If the configured fee policy won't even allow the wallet to meet the relay
 fee the transaction creation may be aborted.

Rebased-From: aa279d6
Github-Pull: #5485

'Sane' was already defined by this code as:
 fee.GetFeePerK() > minRelayFee.GetFeePerK() * 10000
 But sanity was only enforced for data loaded from disk.

Note that this is a pretty expansive definition of 'sane': A 10 BTC
 fee is still passes the test if its on a 100kb transaction.

This prevents a single insane fee on the network from making us reject
 our stored fee data at start.  We still may reject valid saved fee
 state if minRelayFee is changed between executions.

This also reduces the risk and limits the damage from a cascading
 failure where one party pays a bunch of insane fees which cases
 others to pay insane fees.

Rebased-From: 6484930
Github-Pull: #5481

Don't allow immediate inv driven block downloads if
a peer already has MAX_BLOCKS_IN_TRANSIT_PER_PEER
active downloads.  Prevents bogus inv spam from
blowing up block transfer tracking data structures.

Rebased-From: c907704
Github-Pull: #5507

Github-Pull: #5512
Rebased-From: dd14a0e

Previously an empty script wouldn't be hashed, and CScriptID would be
assigned the incorrect value of 0 instead. This bug can be seen in the
RPC decodescript command:

    $ btc decodescript ""
    {
        "asm" : "",
        "type" : "nonstandard",
        "p2sh" : "31h1vYVSYuKP6AhS86fbRdMw9XHieotbST"
    }

Correct output:

    $ btc decodescript ""
    {
        "asm" : "",
        "type" : "nonstandard",
        "p2sh" : "3J98t1WpEZ73CNmQviecrnyiWrnqRhWNLy"
    }

Rebased-From: d78f0da
Github-Pull: #5541

Rebased-From: 566c6cb
Github-Pull: #5536

Rebased-From: a15dba5
Github-Pull: #5533

Rebased-From: f9c571a
Github-Pull: #5565

Rebased-From: 06206bb
Github-Pull: 5571

I'm not comfortable with retaining this entry.

Rebased-From: a094b3d
Github-Pull: #5545

Besides giving a nicer error, this also prevents logging arbitrary data (which could have been used to exploit log readers) into debug.log

Rebased-From: 7f71813
Github-Pull: #5499

- Avoid ambiguous language regarding when transactions confirm
- Elaborate on downgrading warning
- Other minor language improvements
- Clarify watch-only behaviour

Github-Pull: #5534

The normative place for these for the entire project is COPYING,
and the main README already has a MIT license section.

Rebased-From: e6df2bb

There is still a redundancy here between configure.ac and
clientversion.h.

Rebased-From: edbc904

Broken hash logic caused all depends on some platforms (osx at least) to end up
with the same build-id. Without this fix, nothing will be rebuilt when recipes
or dependencies change.

Rebased-From: d57b303
Github-Pull: #5586

Rebased-From: 643415a
Github-Pull: #5583

Rebased-From: e64e084e95ca85b038c7f65ad0824d14d03bc044
Github-Pull: #5581

Rebased-From: 0d50c2f
Github-Pull: #5569

With the splashscreen being able to be closed it is possible to
shutdown during the lengthy verifyDB method. (Takes about a minute
on my machine). This change allows us to shutdown much sooner.

Github-Pull: #5557
Rebased-From: 70477a0

4a3d3e2 Fix typo in release notes (Peter Todd)

Rebased-From: be22b3d
Github-Pull: #5532

Github-Pull: #5528
Rebased-From: 2a3d988 a089c50 2c14d15

Rebased-From: 1c52aad
Github-Pull: #5535

Otherwise, if CCoinsViewCache::ModifyCoins throws an exception in between
setting hasModifier and constructing the CCoinsModifier, the cache ends up
in an inconsistent state, resulting in an assert failure in the next
modification.

Bug discovered by Wladimir J. van der Laan.

Rebased-From: 1c52aad
Github-Pull: #5597

Rebased-From: e413457
Github-Pull: #5597

2ecd294 Bugfix: configure: Correctly detect "nothing to build" condition (Luke Dashjr)
b7a4ecc Bugfix: Only check for boost when building code that requires it (Luke Dashjr)
a19eeac Bugfix: configure: Check for openssl/ec.h (Luke Dashjr)
fe925e2 Use EXTRA_LIBRARIES instead of noinst_LIBRARIES so we can avoid building unused code (Cory Fields)

Github-Pull: #5575
Rebased-From: 1eb1e65

If these are going to fail in bitcoind, they should fail in the tests as well.

Github-Pull: #5604
Rebased-From: d58c5d6