Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

claimpegin should not succeed if it is double-claiming a tx already in mempool or blockchain #613

Closed
stevenroose opened this issue May 7, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@stevenroose
Copy link
Member

commented May 7, 2019

No description provided.

@instagibbs

This comment has been minimized.

Copy link
Collaborator

commented May 7, 2019

To elaborate, the wallet should not report success(a txid).

Instead:

  1. Check IsPeginSpent for UTXO db check
  2. Check if that input is already in the mempool as spent.

instagibbs added a commit that referenced this issue May 8, 2019

Merge #614: Improve double pegin claim behavior
52ef283 Improve the fedpeg test with extra double claim tests (Steven Roose)
48a82fa Make claimpegin fail in the case of a double claim (Steven Roose)
af22646 Prevent pegin double spends from entering the mempool (Steven Roose)
50c5570 Report IsValidPeginWitness error message (Steven Roose)

Pull request description:

  Fixes #612 and #613.

  - prevents a double claim from entering mempool
  - makes `claimpegin` throw an exception when trying to double claim a pegin
  - check the last commit message on all the extra cases that are tested.

Tree-SHA512: dd9602cd4bc78a3e8f7a6b566f881ede09dba54900425348c1eb528268a3e869416e3c9ca97c1a8da4d120875ef59c4e21a857256312ce77e06b7b6ae04abf92

@instagibbs instagibbs closed this May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.