Skip to content

Conversation

@tomt1664
Copy link
Member

Only apply the consensus check for the con_mandatory_coinbase destination to coinbase outputs for policyAsset. This is in preparation for issued asset fee support, allowing non-policy asset (issued assets) to have custom destinations (including AMP destinations).

This is a consensus change and a technical hardfork when deployed, however as there is no existing support in Elements for either creating blocks with issued asset fees or accepting/relaying issued asset fee transactions, and can therefore be safely released and deployed.

@tomt1664 tomt1664 requested a review from delta1 September 10, 2025 15:38
@psgreco psgreco requested a review from apoelstra September 10, 2025 19:56
@apoelstra
Copy link
Member

This is a consensus change and a technical hardfork when deployed, however as there is no existing support in Elements for either creating blocks with issued asset fees or accepting/relaying issued asset fee transactions, and can therefore be safely released and deployed.

To be clearer: this is more than a "technical" hardfork. The point is that exploiting it to split the network can only be done by a quorum of blocksigners, who cannot do it by accident because their existing software does not support it (and who, by their position as blocksigners, are already trusted not to fork the network on purpose.)

Therefore, any further changes to create non-policyAsset coinbase outputs will need to be coordinated with a flag day etc. But releasing this support ASAP minimizes the chances of people missing such a flag day, if and when one is scheduled.

@apoelstra
Copy link
Member

utACK b543259

Copy link
Member

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK b543259

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b543259; successfully ran local tests

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b543259; successfully ran local tests

@tomt1664 tomt1664 merged commit e145690 into ElementsProject:master Sep 19, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants