New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.17] Add new Elements opcodes #495

Merged
merged 10 commits into from Jan 15, 2019

Conversation

Projects
None yet
2 participants
@stevenroose
Copy link
Member

stevenroose commented Jan 8, 2019

Opcode parity with elements-0.14.1

@stevenroose stevenroose referenced this pull request Jan 9, 2019

Open

Update elements to Bitcoin Core version 0.17.0 #398

16 of 28 tasks complete

@stevenroose stevenroose force-pushed the stevenroose:e17-opcodes branch from a69ac1b to 4ec1d91 Jan 10, 2019

stevenroose added some commits Jan 9, 2019

Re-enable several disabled opcodes
Re-enabled opcodes are:

- OP_CAT
- OP_SUBSTR
- OP_LEFT
- OP_RIGHT
- OP_INVERT
- OP_AND
- OP_OR
- OP_XOR
- OP_LSHIFT
- OP_RSHIFT
Add test cases for OP_SUBSTR_LAZY
Signed-off-by: Steven Roose <steven@stevenroose.org>

@stevenroose stevenroose changed the title [WIP] Add new Elements opcodes Add new Elements opcodes Jan 11, 2019

@instagibbs
Copy link
Collaborator

instagibbs left a comment

utACK I can confirm the code matches elements-0.14.1 code along with activated tests

Show resolved Hide resolved src/script/interpreter.cpp Outdated

stevenroose added some commits Jan 14, 2019

Make OP_DETERMINISTICRANDOM endian-safe
Fixing a TODO from elements-0.14.1.

Signed-off-by: Steven Roose <steven@stevenroose.org>

@stevenroose stevenroose changed the title Add new Elements opcodes [0.17] Add new Elements opcodes Jan 14, 2019

@instagibbs

This comment has been minimized.

Copy link
Collaborator

instagibbs commented Jan 14, 2019

re-utACK a09e63f

@instagibbs instagibbs merged commit a09e63f into ElementsProject:elements-0.17 Jan 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

instagibbs added a commit that referenced this pull request Jan 15, 2019

Merge #495: [0.17] Add new Elements opcodes
a09e63f Make OP_DETERMINISTICRANDOM endian-safe (Steven Roose)
1967112 Fix typo in comment (Steven Roose)
aa7c92e Add test cases for OP_SUBSTR_LAZY (Steven Roose)
547d3a0 Add OP_SUBSTR_LAZY (Steven Roose)
9fea017 Add test cases for the re-enabled opcodes (Steven Roose)
13e1103 Re-enable several disabled opcodes (Steven Roose)
4ec1d91 Add unit tests for OP_CHECKSIGFROMSTACK (Steven Roose)
c27ea98 Add OP_CHECKSIGFROMSTACK[VERIFY] (Steven Roose)
8c20371 Add OP_DETERMINISTICRANDOM unit tests (Steven Roose)
358a1bb Add OP_DETERMINISTICRANDOM (Steven Roose)

Pull request description:

  Opcode parity with elements-0.14.1

Tree-SHA512: ebb8dd329ea4d4123189a9f0fa8fd95dd5ae134d202c2b640f868b8f0608948c24d404bdb487c20b39b398bc933dfd412e61ec562c3eb907b59fb986808cff3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment