Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port asset tutorial, update to 0.17+ API #548

Closed

Conversation

Projects
None yet
3 participants
@instagibbs
Copy link
Collaborator

commented Mar 29, 2019

cc @wintercooled

I didn't port the bash version because I don't feel like rewriting everything to work in bash.

resolves #546

@instagibbs

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 29, 2019

bunch of linter nits to work through, will get back to these later

@instagibbs instagibbs force-pushed the instagibbs:asset_tutorial_master branch from e29eb1c to 4c157da Mar 29, 2019

@@ -0,0 +1,191 @@

This comment has been minimized.

Copy link
@stevenroose

stevenroose Apr 1, 2019

Member

This file is just an exact copy, right?

@stevenroose

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

utACK 4c157da

@stevenroose stevenroose closed this Apr 1, 2019

stevenroose added a commit that referenced this pull request Apr 1, 2019

Merge #548: Port asset tutorial, update to 0.17+ API
4c157da Port asset tutorial, update to 0.17+ API (Gregory Sanders)

Pull request description:

  cc @wintercooled

  I didn't port the bash version because I don't feel like rewriting everything to work in bash.

  resolves #546

Tree-SHA512: b1ce9180dc49d5cba0eeba8813e03f486c73f7d3786a85e8aa698eeb5146afb6a89dd9a48611364261937d246368c46843d6666d7eea6b64f7800557e47d083f
@stevenroose

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Whoops, I hit the button "comment and close" by accident. Well, I merged it in the meantime.

@wintercooled

This comment has been minimized.

Copy link

commented Apr 1, 2019

@stevenroose I will test this as it is merged now - I was testing the PR but easier to do from master. I will also test the full tutorial run through (bash based) here to make sure it still works: https://elementsproject.org/elements-code-tutorial/easy-run-code

I could really do with adding that code as a test to elements then we will know if changes ever break the tutorial on the .org site - the link above takes all the steps in the tutorial and runs them in one job lot. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.