Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
add code to test partial blinding functionality to qa/rpc-tests #550
The only place where auxiliary_generators is specified when calling BlindTransaction is from
To my taste, especially because this code was already related to a bug (#514), it is future-bug-prone to leave it dangling and not covered by tests. My humble opinion: I feel that it is better to remove this code and and enforce len(vin) == len(auxiliary_generators) at the start of BlindTransaction, and if there is a need for this functionality in the future, reintroduce the code.
Apr 3, 2019
1 check passed
On Tue, Apr 9, 2019, 5:36 PM Steven Roose ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In test/functional/feature_confidential_transactions.py <#550 (comment)> : > + # 3 inputs and 1 output, but no fee output, and + # it was blinded with 3 asset commitments, that means + # the final transaction should have 3 inputs. + btx = CTransaction() + btx.deserialize(io.BytesIO(hex_str_to_bytes(blindtx))) + + # Unblinded transaction, with 3 inputs and 2 outputs. + # We will add them to the other transaction to make it complete. + ubtx = CTransaction() + ubtx.deserialize(io.BytesIO(hex_str_to_bytes(rawtx2))) + + # We will add inputs and outputs of unblinded transaction + # on top of inputs and outputs of the blinded, but incomplete transaction. + # We also append empty witness instances to make witness arrays match + # vin/vout arrays + btx.wit.vtxinwit.append(CTxInWitness()) @instagibbs <https://github.com/instagibbs> I guess I took your word for it. Should I PR a nitfix? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#550 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFgC0-DmVbM-ELoCgm2odZsxv1PLSyYiks5vfQfGgaJpZM4cS7_d> .