Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mempool_package: make sure small UTXOs aren't selected for spending c… #575

Merged

Conversation

Projects
None yet
2 participants
@instagibbs
Copy link
Collaborator

instagibbs commented Apr 12, 2019

…hain

Was causing random errors depending on the response of listunspent, which may be including smaller UTXOs for whatever reason.

@instagibbs instagibbs force-pushed the instagibbs:mempool_package_output branch from 9e62c4f to 49d3a63 Apr 12, 2019

@instagibbs

This comment has been minimized.

Copy link
Collaborator Author

instagibbs commented Apr 12, 2019

rebased onto master due to address issues fixed

if utxo['amount'] != Decimal(50):
continue
utxos.append(utxo)
assert len(utxos) != 0

This comment has been minimized.

Copy link
@stevenroose

stevenroose Apr 15, 2019

Member

Since you're using 2 of the utxos, should you assert it's at least length 2?

This comment has been minimized.

Copy link
@instagibbs

instagibbs Apr 15, 2019

Author Collaborator

i was lazy and didn't want to look up the greater than assert... fixed

@instagibbs instagibbs force-pushed the instagibbs:mempool_package_output branch from 49d3a63 to fb184c8 Apr 15, 2019

@stevenroose stevenroose merged commit fb184c8 into ElementsProject:master Apr 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

stevenroose added a commit that referenced this pull request Apr 15, 2019

Merge #575: mempool_package: make sure small UTXOs aren't selected fo…
…r spending c…

fb184c8 mempool_package: make sure small UTXOs aren't selected for spending chain (Gregory Sanders)

Pull request description:

  …hain

  Was causing random errors depending on the response of listunspent, which may be including smaller UTXOs for whatever reason.

Tree-SHA512: 1a083026f67131374478cc70abd41a3c4918f7867d0ede75a3ddf331e485ed11bc8a46477a7ecf733faa40130529f2b83f7b1a8a56d8434a3908a0592cdd61ef
@stevenroose

This comment has been minimized.

Copy link
Member

stevenroose commented Apr 15, 2019

ACK fb184c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.