Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix default permitsigdata value not working on converttopsbt command #607
We're not really supporting PSBT for Elements yet. The
I added an extra test to catch the error, but it's not actually executed.
@instagibbs, up to you to decide if it's worth having this patched right now. I cherry-picked that fix commit literally from the catchup PR I'm working on, so if we don't patch it here, it will get patched while catching up.
Oh, I remember noticing that and probably should have filed it at the time I noticed it. I believe the effect of the bug is that "permitsigdata" is actually "prohibitsigdata", defaulting to true (that is, the sense of the flag is reversed if you supply it but the default is correct.)
I can't imagine when you would run into this; trying to convert a signed transaction to a (unsigned) PSBT doesn't really seem like a sensible thing to ever do. So I don't have strong feelings about fixing it.