Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports + version bump for v0.18.1.6 #836

Merged
merged 8 commits into from Mar 18, 2020

Conversation

@stevenroose
Copy link
Member

stevenroose commented Mar 17, 2020

v0.18.1.6 changelog:

  • Reduce mintxfee to 0.1 sat/vbyte and fallback fee to 2 sat/vb
  • Switch default bits of hiding to 52
  • check for hardened derivation steps early in initpegoutwallet
  • Create witness outputs for (re)issueasset RPC
  • Fix claimpegin and createrawpegin support for multiwallet
  • Place the mainchain RPC warmup message in a better place

Backported commits:

commit bfb77ad44d03985284b80048d41a8a87d71e698d (origin/pr/835, mine/mintxfee, mintxfee)
Author: Steven Roose <steven@stevenroose.org>
Date:   Tue Mar 17 12:47:03 2020 +0000

    Reduce mintxfee to 0.1 sat/vbyte and fallback fee to 2 sat/vb

commit 26e5490e832758b528966c79ee3f65dee5ae86fd
Author: Gregory Sanders <gsanders87@gmail.com>
Date:   Tue Dec 3 16:14:13 2019 -0500

    Switch default bits of hiding to 52

commit a7b41e1f7e47ed7d046f8098d1c2ffc1018f8e4c (upstream/pr/829, origin/pr/829, instagibbs/check_hardened)
Author: Gregory Sanders <gsanders87@gmail.com>
Date:   Tue Mar 3 09:52:57 2020 -0500

    initpegoutwallet: check for hardened derivation steps early

commit 91583b6e0a9e86af66fb9a1829967656b69a0e8b (upstream/pr/825, origin/pr/825, instagibbs/witness_issue)
Author: Gregory Sanders <gsanders87@gmail.com>
Date:   Mon Feb 24 09:32:21 2020 -0500

    Create witness outputs for (re)issueasset RPC

commit c5cb7148472c9f4419619888953e0130d3844d4f (upstream/pr/818, origin/pr/818, mine/msg-warmup, msg-warmup)
Author: Steven Roose <steven@stevenroose.org>
Date:   Tue Feb 18 15:15:52 2020 +0000

    Place the mainchain RPC warmup message in a better place

commit fc841c8047c21443e5ff1f2de8e8e75637b873b0 (upstream/pr/813, origin/pr/813)
Author: Glenn Willen <gwillen@nerdnet.org>
Date:   Thu Feb 6 23:08:56 2020 -0800

    Fix claimpegin and createrawpegin support for multiwallet.
gwillen and others added 5 commits Feb 7, 2020
Fix multiple issues with claimpegin and createrawpegin support for
multiple loaded wallets:

- Failure to call EnsureWalletIsAvailable would cause a crash when multiple
  wallets were loaded, but one was not specified in the RPC call.
- Failure to propagate the request URL from claimpegin when making an
  internal call to another RPC would result in failure when multiple
  wallets were loaded, by failing to specify one for that call.

Add a regression test to the feature_fedpeg.py test: at a critical point,
create a second wallet on the sidechaind, and set up the RPC client to
use the first one, to check that it still works correctly.
@stevenroose stevenroose force-pushed the stevenroose:bps-18.1.6 branch from 8d29395 to 17f8e74 Mar 17, 2020
stevenroose added 3 commits Mar 16, 2020
Copy link
Contributor

jonasnick left a comment

utACK 17f8e74

@stevenroose stevenroose merged commit 49d3c1c into ElementsProject:elements-0.18 Mar 18, 2020
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.