Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove the min(max( construction for the ct_exponent argument #840
We removed the similar construction for ct_bits in an earlier commit. The construction is to keep the value between -1 and 18. This kind of means that a user that inputs a value outside that range will not get an error, but will use the value on the edge of the range instead. It's probably better to return an error (generated by secp256k1) in the case of invalid input.
stevenroose added a commit that referenced this pull request
Mar 31, 2020
…ct_exponent argument 35c83bd Remove the min(max( construction for the ct_exponent argument (Steven Roose) Pull request description: Backport of #840. @dgpv Could you review again? Tree-SHA512: e212bc04e314bfd8a8e7b7c9c3d5620ad1b6f603706cc038136a655ab729f49c3430f70b0a9baa2d04a2e0bdc9e0aaced413d3cb0d4a424e386b50322b958dc2
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.