Jump to conversation
Unresolved conversations (2)
@apoelstra apoelstra Jun 25, 2021
How about we remove `CHECKSIGFROMSTACK` and leave only the VERIFY variant?
doc/tapscript_opcodes.md
sanket1729 JeremyRubin
@apoelstra apoelstra Jun 25, 2021
I'm torn between having the "less than or equal" opcodes and requiring the user do `GREATERTHAN` `NOT`. What do others think?
doc/tapscript_opcodes.md
sanket1729 JeremyRubin
Resolved conversations (10)
@apoelstra apoelstra Jun 25, 2021
nit: missing a couple backticks between `a_top` and `0`
Outdated
doc/tapscript_opcodes.md
@apoelstra apoelstra Jun 25, 2021
Maybe we shoud "otherwise end the script with success" so that we can softfork in new data?
Outdated
doc/tapscript_opcodes.md
sanket1729
@apoelstra apoelstra Jun 25, 2021
I think it might be simpler to not name these since they aren't really "opcodes" now.
Outdated
doc/tapscript_opcodes.md
@kallewoof kallewoof Dec 22, 2020
```suggestion - Pop the stack as minimal `CScriptNum` as `n`. The implementation is exactly the same as `OP_INSPECTINPUT`, but uses the current input instead of reading the input from stack. The names of the `OP_INSPECTINPUTx` would be replaced by `OP_INSPECTCURRENTINPUTx` ```
Outdated
doc/tapscript_opcodes.md
@kallewoof kallewoof Dec 22, 2020
```suggestion 1. **Streaming Opcodes for streaming hashes**: There is an existing MAX_SCRIPT_ELEMENT_SIZE is 520 bytes, that is the maximum message size that OP_SHA256 can operate on. This allows hashing on more than 520 bytes while still preserving the existing security against resource exhaustion attacks. The proposal for this is still under discussion in https://github.com/ElementsProject/elements/pull/817. We suggest the latest scheme suggested by Russel O'Connor ```
Outdated
doc/tapscript_opcodes.md
@dgpv dgpv Dec 10, 2020
should be "do not error if" rather than "is" ?
Outdated
doc/tapscript_opcodes.md
@dgpv dgpv Dec 10, 2020
should be `OP_PUSH256NUM_1`
Outdated
doc/tapscript_opcodes.md
@dgpv dgpv Dec 10, 2020
Can be substituted with `OP_INSPECTINPUTINDEX OP_INSPECTINPUTx`, is it worth it to add 9 opcodes to save 2 bytes ?
Outdated
doc/tapscript_opcodes.md
sanket1729
@dgpv dgpv Dec 10, 2020
What is the context when hash algorithms besides SHA256 would be needed ?
Outdated
doc/tapscript_opcodes.md
sanket1729 dgpv
@dgpv dgpv Dec 10, 2020
"Pop" used twice
Outdated
doc/tapscript_opcodes.md