New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No accidental wumbo #2095

Merged
merged 6 commits into from Nov 21, 2018

Conversation

Projects
None yet
3 participants
@rustyrussell
Copy link
Contributor

rustyrussell commented Nov 20, 2018

With some cleanups along the way...

@rustyrussell rustyrussell requested review from cdecker and niftynei Nov 20, 2018

@cdecker

This comment has been minimized.

Copy link
Member

cdecker commented Nov 20, 2018

ACK 548834f

@niftynei
Copy link
Collaborator

niftynei left a comment

lgtm

@rustyrussell rustyrussell force-pushed the rustyrussell:guilt/no-accidental-wumbo branch from 548834f to 6c4d6c5 Nov 21, 2018

@rustyrussell

This comment has been minimized.

Copy link
Contributor

rustyrussell commented Nov 21, 2018

Simple rebase...

rustyrussell added some commits Nov 21, 2018

gossipd: store chainparams internally.
We keep a chain_hash in struct daemon, becayse otherwise we end up with
`&peer->daemon->rstate->chainparams->genesis_blockhash` which is a bit
ridiculous.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
struct channel: remove most helpers.
They were not universally used, and most are trivial accessors anyway.

The exception is getting the channel reserve: we have to multiply by 1000
as well as flip direction, so keep that one.

The BOLT quotes move to `struct channel_config`.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
struct channel: keep a copy of configs, not just pointers.
This simplifies lifetime assumptions.  Currently all callers keep the
original around, but everything broke when I changed that in the next
patch.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
channeld: don't keep local copy of config.
We keep it in struct channel already.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

@cdecker cdecker force-pushed the rustyrussell:guilt/no-accidental-wumbo branch from 6c4d6c5 to b4b081e Nov 21, 2018

@cdecker

This comment has been minimized.

Copy link
Member

cdecker commented Nov 21, 2018

Re-rebase and fixup due to missing header.

@cdecker cdecker force-pushed the rustyrussell:guilt/no-accidental-wumbo branch from b4b081e to 6336aef Nov 21, 2018

rustyrussell added some commits Nov 21, 2018

channeld: speak no wumbo.
We cap our htlc_maximum_msat at 2^32-1.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
gossipd: hear no wumbo.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

@rustyrussell rustyrussell force-pushed the rustyrussell:guilt/no-accidental-wumbo branch from 6336aef to debb316 Nov 21, 2018

@rustyrussell

This comment has been minimized.

Copy link
Contributor

rustyrussell commented Nov 21, 2018

I think we both force pushed the same fix :)

@rustyrussell

This comment has been minimized.

Copy link
Contributor

rustyrussell commented Nov 21, 2018

Ack debb316

@rustyrussell rustyrussell merged commit 29b672b into ElementsProject:master Nov 21, 2018

2 checks passed

ackbot PR ack'd by rustyrussell
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment