New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bolt11: accept lightning: prefix. #2096

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Projects
None yet
3 participants
@rustyrussell
Copy link
Contributor

rustyrussell commented Nov 20, 2018

The Blockstream store produces these, for example, so let's ignore them.

bolt11: accept lightning: prefix.
The Blockstream store produces these, for example, so let's ignore them.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@ZmnSCPxj
Copy link
Collaborator

ZmnSCPxj left a comment

ACK c0e09f3

Some minor nit, but inconsequential-in-practice anyway.

* If a URI scheme is desired, the current recommendation is to either
* use 'lightning:' as a prefix before the BOLT-11 encoding
*/
if (strstarts(str, "lightning:") || strstarts(str, "LIGHTNING:"))

This comment has been minimized.

@ZmnSCPxj

ZmnSCPxj Nov 20, 2018

Collaborator

Why we do not accept lIghtnIng:? Would it be better to apply some case-conversion?

(bech32 is case-insensitive in any case....)

This comment has been minimized.

@cdecker

cdecker Nov 20, 2018

Member

bech32 does not allow for mixed case.

@cdecker
Copy link
Member

cdecker left a comment

ACK c0e09f3

@cdecker cdecker merged commit debbdc0 into ElementsProject:master Nov 20, 2018

2 checks passed

ackbot PR ack'd by ZmnSCPxj, cdecker
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment