Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return both style addresses (and eventually, more?) from newaddr #2391

Merged
merged 2 commits into from Mar 4, 2019

Conversation

Projects
None yet
2 participants
@rustyrussell
Copy link
Contributor

rustyrussell commented Feb 23, 2019

No description provided.

@rustyrussell rustyrussell requested a review from cdecker as a code owner Feb 23, 2019

@rustyrussell rustyrussell added this to the v0.7 milestone Feb 23, 2019

@rustyrussell rustyrussell force-pushed the rustyrussell:guilt/both-addresses branch from 0a72b2f to 7972ec1 Feb 23, 2019

@rustyrussell

This comment has been minimized.

Copy link
Contributor Author

rustyrussell commented Feb 23, 2019

We may squeeze this in after rc1, given it's fairly simple and Shesek asked for it, but I don't want to hold up rc1 just for this...

@cdecker

This comment has been minimized.

Copy link
Member

cdecker commented Feb 23, 2019

ACK 7972ec1

@rustyrussell

This comment has been minimized.

Copy link
Contributor Author

rustyrussell commented Feb 26, 2019

This will have to wait, as I missed it for rc2. Marking for 0.7.1

@rustyrussell rustyrussell modified the milestones: v0.7, 0.7.1 Feb 26, 2019

@cdecker cdecker force-pushed the rustyrussell:guilt/both-addresses branch from 7972ec1 to e0862f5 Mar 2, 2019

@cdecker

This comment has been minimized.

Copy link
Member

cdecker commented Mar 2, 2019

Rebased on top of #2430 since we switched over to a new era 😉
ACK e0862f5

rustyrussell added some commits Mar 4, 2019

newaddr: support getting both bech32 and p2sh addresses.
Higher layers consume less addresses this way.

Fixes: #2390
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
newaddr: deprecate 'address' output.
It doesn't make sense with 'all', and it's ok to be explicit.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

@rustyrussell rustyrussell force-pushed the rustyrussell:guilt/both-addresses branch from e0862f5 to f9f9e1b Mar 4, 2019

@rustyrussell

This comment has been minimized.

Copy link
Contributor Author

rustyrussell commented Mar 4, 2019

Re-rebased :)

Ack f9f9e1b

@cdecker cdecker merged commit 049f235 into ElementsProject:master Mar 4, 2019

2 checks passed

ackbot PR ack'd by rustyrussell
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.