Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setchannelfee for 'all' channels #2470

Merged

Conversation

Projects
None yet
2 participants
@m-schmoock
Copy link
Collaborator

m-schmoock commented Mar 14, 2019

based ontop of PR #2342

Will give an option to use the setchannelfee command to update all channels at once.
Adds feature, doc and test.

@m-schmoock m-schmoock requested a review from cdecker as a code owner Mar 14, 2019

@m-schmoock m-schmoock force-pushed the m-schmoock:feerate-per-channel-all branch from 75d0885 to 78cc95b Mar 15, 2019

@m-schmoock

This comment has been minimized.

Copy link
Collaborator Author

m-schmoock commented Mar 15, 2019

Note: We should merge #2471 before this one

Update: Done

@m-schmoock m-schmoock force-pushed the m-schmoock:feerate-per-channel-all branch 2 times, most recently from 1a6b58d to ff8beee Mar 16, 2019

Show resolved Hide resolved lightningd/peer_control.c Outdated
Show resolved Hide resolved lightningd/peer_control.c Outdated

@m-schmoock m-schmoock force-pushed the m-schmoock:feerate-per-channel-all branch 3 times, most recently from a0df067 to 07af3ef Mar 17, 2019

@rustyrussell
Copy link
Contributor

rustyrussell left a comment

This is excellent! Minor style things only...

Show resolved Hide resolved lightningd/peer_control.c Outdated

m-schmoock added some commits Mar 16, 2019

feat: add option to setchannelfee for all channels
- This will make a channel loop when 'id' argument was "all".
- The response will now contain an array of objects (peer_id, scid, ...)
- It will skip channels in invalid states.
- Moves iffy channel/peer param stuff to param_channel_or_all
test: adds test_setchannelfee_all
- will also update old setchannelfee tests to new command output

@m-schmoock m-schmoock force-pushed the m-schmoock:feerate-per-channel-all branch from 07af3ef to 2c8e812 Mar 18, 2019

@m-schmoock

This comment has been minimized.

Copy link
Collaborator Author

m-schmoock commented Mar 18, 2019

@rustyrussell well that was an easy fix ;)

@rustyrussell
Copy link
Contributor

rustyrussell left a comment

Ack 2c8e812

@rustyrussell rustyrussell merged commit 1cd0ae1 into ElementsProject:master Mar 19, 2019

2 checks passed

ackbot PR ack'd by rustyrussell
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.