Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor small UX fixes #2554

Merged
merged 3 commits into from Apr 11, 2019

Conversation

Projects
None yet
3 participants
@rustyrussell
Copy link
Contributor

commented Apr 10, 2019

Really should be separate PRs, but I was being lazy.

@rustyrussell rustyrussell requested a review from cdecker as a code owner Apr 10, 2019

@rustyrussell rustyrussell force-pushed the rustyrussell:json-cli-fix branch from 0bf1abb to 7b5ae2b Apr 10, 2019

@cdecker

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

One of the mocks needs to be implemented now, it seems it's actually being called now. Otherwise this is looking good.

@@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- JSON API: `invoice` expiry defaults to 7 days, and can have s/m/h/d/w suffixes.

This comment has been minimized.

Copy link
@niftynei

niftynei Apr 10, 2019

Collaborator

💯

rustyrussell added some commits Apr 10, 2019

lightning-cli: don't produce bad JSON if fields contain ".
The user can explicitly create such things (within [] or ") as we paste
those cases literally, but not for the simple cases.

Fixes: #2550
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
invoice: change default expiry to 7 days.
For online services, shorter may be fine, but for casual use I'm usually
in a different timezone than the payer, so needs to be at least 1 day.

Certainly 1 hr is short if they have to open a channel.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
invoice: allow suffixes.
Makes it much easier to set it to 6 hours, for example.

Fixes: #2551
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

@rustyrussell rustyrussell force-pushed the rustyrussell:json-cli-fix branch from 7b5ae2b to ec6719d Apr 10, 2019

@niftynei niftynei self-requested a review Apr 11, 2019

@niftynei

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

ACK ec6719d

@niftynei niftynei merged commit ba41238 into ElementsProject:master Apr 11, 2019

2 checks passed

ackbot PR ack'd by niftynei
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.