Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylightning: reorder LightningRpc methods and add missing ones #2631

Merged

Conversation

Projects
None yet
3 participants
@darosior
Copy link
Contributor

commented May 13, 2019

This PR orders alphabetically the RPC command methods in the LightningRpc class, and then add the missing ones.

@darosior darosior requested a review from cdecker as a code owner May 13, 2019

@m-schmoock
Copy link
Collaborator

left a comment

Edit: ignore this :D

@darosior darosior force-pushed the darosior:pylightning_reorder_addmissing branch from d27c7b1 to 57dca6a May 13, 2019

pylightning: Add missing RPC command as LightningRpc methods
Added 'autocleaninvoice', 'check', 'setchannelfee'

@darosior darosior force-pushed the darosior:pylightning_reorder_addmissing branch from 57dca6a to 761ebc4 May 13, 2019

@m-schmoock

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

Looks better now for Jenkins

@m-schmoock

This comment has been minimized.

Copy link
Collaborator

commented May 13, 2019

ACK 57dca6a

@cdecker

This comment has been minimized.

Copy link
Member

commented May 13, 2019

ACK 761ebc4

@cdecker cdecker merged commit 12f703e into ElementsProject:master May 13, 2019

2 checks passed

ackbot PR ack'd by cdecker
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.