Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
add signet support #2816
Jul 22, 2019
2 checks passed
ackbot PR ack'd by ZmnSCPxj
continuous-integration/travis-ci/pr The Travis CI build passedDetails
Yeah ideally this would have been held til the bitcoind PR was merged; I wasn’t aware of the status of the upstream dependency til @cdecker pointed it out (after it was merged). It’s also missing a CHANGELOG entry…
On Tue, Jul 23, 2019 at 19:55 kallewoof ***@***.***> wrote: Ahh, that is a good point. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2816?email_source=notifications&email_token=AAIMAKM2YF3SHWC3FKWFFETQA6R75A5CNFSM4IE4YKQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2U223Q#issuecomment-514436462>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIMAKP55PHDVX5QFISSWFDQA6R75ANCNFSM4IE4YKQA> .
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.