Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add signet support #2816

Merged

Conversation

@kallewoof
Copy link
Contributor

commented Jul 18, 2019

This PR adds support for signet networks.

Blocked by: bitcoin/bitcoin#16411

See also: https://en.bitcoin.it/wiki/Signet

@kallewoof kallewoof requested a review from cdecker as a code owner Jul 18, 2019

@kallewoof kallewoof force-pushed the kallewoof:2019-07-18-signet-on-master branch 2 times, most recently from d6af75a to ca06167 Jul 18, 2019

@cdecker

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

Awesome, thanks for the PR @kallewoof. I think this is a good addition once bitcoin/bitcoin#16411 is merged ^^

@ZmnSCPxj
Copy link
Collaborator

left a comment

Mostly good, minor suggestion.

wallet/wallet.c Outdated Show resolved Hide resolved

@kallewoof kallewoof force-pushed the kallewoof:2019-07-18-signet-on-master branch 4 times, most recently from 718a622 to 618bedc Jul 19, 2019

bitcoin/chainparams.c Outdated Show resolved Hide resolved

@kallewoof kallewoof force-pushed the kallewoof:2019-07-18-signet-on-master branch from 618bedc to bdf7461 Jul 19, 2019

bitcoin/chainparams.c Outdated Show resolved Hide resolved
bitcoin/chainparams.c Outdated Show resolved Hide resolved
wallet/wallet.c Outdated Show resolved Hide resolved

@kallewoof kallewoof force-pushed the kallewoof:2019-07-18-signet-on-master branch from bdf7461 to 7eb368a Jul 19, 2019

@kallewoof

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

@ZmnSCPxj Thanks for the review, I believe I addressed everything you pointed at.

@ZmnSCPxj
Copy link
Collaborator

left a comment

ACK ad84897

@niftynei
Copy link
Collaborator

left a comment

nice. suggestion to also update: jsonrpc.c:979

.when_lightning_became_cool = 1,
.p2pkh_version = 125,
.p2sh_version = 87,
.testnet = false,

This comment has been minimized.

Copy link
@niftynei

niftynei Jul 20, 2019

Collaborator

I'd argue that we should set this to true. see lightningd/bitcoin.c:380-387 and lightningd/options.c:685-688 for rationale.

@kallewoof kallewoof force-pushed the kallewoof:2019-07-18-signet-on-master branch from 7eb368a to d12c329 Jul 20, 2019

@kallewoof

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

@niftynei Thanks! I switched .testnet to true and updated comment in jsonrpc.c.

@ZmnSCPxj

This comment has been minimized.

Copy link
Collaborator

commented Jul 20, 2019

ACK d12c329

@niftynei niftynei merged commit 918e130 into ElementsProject:master Jul 22, 2019

2 checks passed

ackbot PR ack'd by ZmnSCPxj
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kallewoof kallewoof deleted the kallewoof:2019-07-18-signet-on-master branch Jul 23, 2019

@ZmnSCPxj

This comment has been minimized.

Copy link
Collaborator

commented Jul 24, 2019

Were we not supposed to hold off on this until bitcoin/bitcoin#16411 was merged?

@kallewoof

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

Ideally, but it's not harmful or causing weird dependency issues. Only thing is people will have to run a custom build of bitcoin core to use this, at the moment.

@ZmnSCPxj

This comment has been minimized.

Copy link
Collaborator

commented Jul 24, 2019

I am more concerned that changes to the bitcoin PR might require changes to this PR, but I suppose the upstream PR is now mostly settled.

@kallewoof

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

Ahh, that is a good point.

@niftynei

This comment has been minimized.

Copy link
Collaborator

commented Jul 24, 2019

@kallewoof

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

Sad, but if you wish, you can revert this PR and I will make a new one once the bitcoin core PR has been merged. If not, I will make sure that any changes done on bitcoin side are duplicated here, in a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.