Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT11 feature support #3020

Merged
merged 2 commits into from Sep 6, 2019

Conversation

@rustyrussell
Copy link
Contributor

commented Sep 3, 2019

As merged in the latest spec.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell added the invoice label Sep 3, 2019
@rustyrussell rustyrussell added this to the 0.7.3 milestone Sep 3, 2019
@rustyrussell rustyrussell requested a review from cdecker as a code owner Sep 3, 2019
@rustyrussell rustyrussell force-pushed the rustyrussell:guilt/base-amp branch from c91bd93 to d262fbc Sep 4, 2019

b11->features = tal_arr(b11, u8, flen);
pull_bits_certain(hu5, data, data_len, b11->features,
data_length * 5, true);

This comment has been minimized.

Copy link
@niftynei

niftynei Sep 4, 2019

Collaborator

spacing here seems off?

This comment has been minimized.

Copy link
@rustyrussell

rustyrussell Sep 5, 2019

Author Contributor

It's actually fine, ut's just a tabs-vs-spaces thing. Weird.

This comment has been minimized.

Copy link
@niftynei

niftynei Sep 6, 2019

Collaborator

@ZmnSCPxj explained it elsewhere as being from a tabs/spaces display problem w/ github (because of the additional '+' at the line start)

@@ -14,6 +14,8 @@
/* We only have 10 bits for the field length, meaning < 640 bytes */
#define BOLT11_FIELD_BYTE_LIMIT ((1 << 10) * 5 / 8)

#define BOLT11_F_BASE_MPP 0

This comment has been minimized.

Copy link
@niftynei

niftynei Sep 4, 2019

Collaborator

defined but unused. is that by design?

This comment has been minimized.

Copy link
@rustyrussell

rustyrussell Sep 5, 2019

Author Contributor

A portent! A hint, of things to come...

But I'll remove it :)

This implements lightningnetwork/lightning-rfc#656

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell force-pushed the rustyrussell:guilt/base-amp branch from d262fbc to 1488c6e Sep 5, 2019
@niftynei

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2019

ack 1488c6e

@niftynei niftynei merged commit a134062 into ElementsProject:master Sep 6, 2019
3 of 4 checks passed
3 of 4 checks passed
bitcoin-bot/acks Check is pending
ackbot PR ack'd by niftynei
bitcoin-bot/fixups PR does not contain unsquashed fixups
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.