Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT11 feature support #3020

Merged
merged 2 commits into from Sep 6, 2019
Merged

Conversation

@rustyrussell
Copy link
Contributor

@rustyrussell rustyrussell commented Sep 3, 2019

As merged in the latest spec.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell added this to the 0.7.3 milestone Sep 3, 2019
@rustyrussell rustyrussell requested a review from cdecker as a code owner Sep 3, 2019

b11->features = tal_arr(b11, u8, flen);
pull_bits_certain(hu5, data, data_len, b11->features,
data_length * 5, true);
Copy link
Collaborator

@niftynei niftynei Sep 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing here seems off?

Copy link
Contributor Author

@rustyrussell rustyrussell Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually fine, ut's just a tabs-vs-spaces thing. Weird.

Copy link
Collaborator

@niftynei niftynei Sep 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZmnSCPxj explained it elsewhere as being from a tabs/spaces display problem w/ github (because of the additional '+' at the line start)

common/bolt11.h Outdated
@@ -14,6 +14,8 @@
/* We only have 10 bits for the field length, meaning < 640 bytes */
#define BOLT11_FIELD_BYTE_LIMIT ((1 << 10) * 5 / 8)

#define BOLT11_F_BASE_MPP 0
Copy link
Collaborator

@niftynei niftynei Sep 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defined but unused. is that by design?

Copy link
Contributor Author

@rustyrussell rustyrussell Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A portent! A hint, of things to come...

But I'll remove it :)

This implements lightning/bolts#656

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@niftynei
Copy link
Collaborator

@niftynei niftynei commented Sep 6, 2019

ack 1488c6e

@niftynei niftynei merged commit a134062 into ElementsProject:master Sep 6, 2019
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants