sphinx: fix potential data leak. #3246
[ Based on #3245 to keep Travis happy: just look at last commit ]
…ossip! It currently works because we inject it so fast that it's still doing the txout lookup, but that's about to change. Signed-off-by: Rusty Russell <email@example.com>
This correctly refreshes the txout entry against aging. Signed-off-by: Rusty Russell <firstname.lastname@example.org>
This prevents a gratuitous lookup of we get a late channel_announce, but even better, it suppresses the "bad gossip" messages in case of a late channel_update, which have plagued Travis (especially since we got aggressive in pushing our own updates). Signed-off-by: Rusty Russell <email@example.com>
Well, we already have a backdoor to set the session_key for testing, so we'd just need another one.
But you're right: generating it this way is Just Good Practice anyway, so let's do that. Take II coming.
lightningnetwork/lightning-rfc#697 https://lists.linuxfoundation.org/pipermail/lightning-dev/2019-November/002288.html We generate it from an hmac using the session secret. It's not clear that this will be useful for reproducing test vectors though, since we don't generate the first 66 bytes, which is what the spec says to do. Reported-by: @Roasbeef Signed-off-by: Rusty Russell <firstname.lastname@example.org>