EXPERIMENTAL: channel upgrade support #4532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
added
the
Optech Make Me Famous!
rustyrussell
force-pushed
the
guilt/channel-upgrade
branch
2 times, most recently
from
7d1571e
to
3b26c2b
Compare
cdecker
force-pushed
the
guilt/channel-upgrade
branch
2 times, most recently
from
45b1e1a
to
9fb05c0
Compare
|
Sorry for the rebase noise, but a merge caused the SQL files to conflict again. ACK 9fb05c0 |
cdecker
previously requested changes
May 27, 2021
|
Simple fix for sql non-portability, and rebased on new quiescence branch. |
rustyrussell
force-pushed
the
guilt/channel-upgrade
branch
from
9fb05c0
to
5c0dac8
Compare
rustyrussell
force-pushed
the
guilt/channel-upgrade
branch
3 times, most recently
from
5bdb1ab
to
7422978
Compare
|
Rebase, and remove first patch (will go into separate PR, but only the rest was acked by @cdecker so I'd rather keep it simple) |
rustyrussell
force-pushed
the
guilt/channel-upgrade
branch
from
7422978
to
97b18ec
Compare
And as Lisa requested, add testcases. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/channel-upgrade
branch
from
97b18ec
to
129ee9e
Compare
rustyrussell
force-pushed
the
guilt/channel-upgrade
branch
from
129ee9e
to
0dd8f03
Compare
…ommitments. Just always handle both cases. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It's a global. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We don't handle our own cheat txs: rather than crash, we should just log broken and limp along. This also makes our upcoming penalty test easier: we don't have to spin up a new node. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…hanges. For quiescence, we can't have sent any updates at all. But for upgrades on reconnection, we may have already added uncommitted HTLCs for retransmission, but they don't count towards "are we quiesced" since they're not sent yet. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/channel-upgrade
branch
from
0dd8f03
to
d4809d8
Compare
|
Fixed elements: we were not ignoring fee outputs in "onchaind: don't rely on knowing option_static_remotekey for unknown commitments.". |
|
Ack d4809d8 (Since fix is trivial, and rest has been reviewed already) |
See lightning/bolts#868 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
For now the only upgrade possible is to enable option_static_remotekey. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Since we will soon be able to activate it on existing channels, we need to mark the threshold. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
No longer a global "on" or "off", it depends on the commitment number. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We don't actually set desired_type yet, but this handles it. Changelog-EXPERIMENTAL: Protocol: we can now upgrade old channels to `option_static_remotekey` from lightning/bolts#868 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…t already. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…de of upgrade. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/channel-upgrade
branch
from
d4809d8
to
519adf7
Compare
|
Finally fixed all the dumb trivial stuff. Self-ack Ack 519adf7 |
fiatjaf
pushed a commit
to fiatjaf/mcldsp
that referenced
this pull request
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4520, though we don't currently use quiescence to force an upgrade.
This is an implementation of lightning/bolts#868, though much of it is more about the mechanics of the upgrade we actually end up supporting (option_static_remotekey).