askrene: add expiration parameter to create-layer #7963
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagrang3
force-pushed
the
askrene-self-destructing-layers
branch
from
ca32c5f to
b021d3d
Compare
This could be useful if we want to create one-time use layers on the flight and not worry about memory leaks (one time used layers that are not removed constitute a memory leak in a sense). Changelog-Added: askrene: add an optional self-destruction timer (expiration parameter) to new layers. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Lagrang3
force-pushed
the
askrene-self-destructing-layers
branch
from
b021d3d to
2c2a4e6
Compare
Contributor
|
I'm hoping that we don't have leaks, and don't have to resort to this! |
Collaborator
Author
|
I am closing this. I guess the same plugin that creates the layer can destroy it himself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be useful if we want to create one-time use layers on the flight and not worry about memory leaks (one time used layers that are not removed constitute a memory leak in a sense).
I would like to re-introduce in the pay command (
xpay-handle-pay=true) the possibility of excluding channelsand nodes using the legacy pay style
excludeparameter.One possible solution is to create a one-time layer with all the channels and nodes listed in the
excludearray as disabled and then pass the call to
xpaywith that temporary layer in the parameters.We make this one-time layer possible by introducing expiration times to layers in this PR.
Changelog-Added: askrene: add an optional self-destruction timer (expiration parameter) to new layers.