From ebf045a5d6e6e17135203aa9f1cecb46bef455b8 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Fri, 15 Aug 2025 10:13:04 +0930 Subject: [PATCH 1/2] pyln-testing: don't run reckless under valgrind. We can timeout if we do (it's Python). Unfortunately I didn't catch the flake. Signed-off-by: Rusty Russell --- contrib/pyln-testing/pyln/testing/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/pyln-testing/pyln/testing/utils.py b/contrib/pyln-testing/pyln/testing/utils.py index 3f663e2bdcf1..caa03513bb9d 100644 --- a/contrib/pyln-testing/pyln/testing/utils.py +++ b/contrib/pyln-testing/pyln/testing/utils.py @@ -859,7 +859,7 @@ def __init__(self, node_id, lightning_dir, bitcoind, executor, valgrind, may_fai if dsn is not None: self.daemon.opts['wallet'] = dsn if valgrind: - trace_skip_pattern = '*python*,*bitcoin-cli*,*elements-cli*,*cln-grpc*,*clnrest*,*wss-proxy*,*cln-bip353*' + trace_skip_pattern = '*python*,*bitcoin-cli*,*elements-cli*,*cln-grpc*,*clnrest*,*wss-proxy*,*cln-bip353*,*reckless' if not valgrind_plugins: trace_skip_pattern += ',*plugins*' self.daemon.cmd_prefix = [ From 0c62c6388c1a1c0f239062485f581eb4ad80d4cf Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Fri, 15 Aug 2025 15:20:32 +0930 Subject: [PATCH 2/2] pytest: fix flake in test_route_by_old_scid ``` 2025-08-14T11:45:41.7353946Z # Now l1 tries to send using old scid: should work 2025-08-14T11:45:41.7354652Z l1.rpc.sendpay(route, inv['payment_hash'], payment_secret=inv['payment_secret']) 2025-08-14T11:45:41.7355321Z > l1.rpc.waitsendpay(inv['payment_hash']) 2025-08-14T11:45:41.7355644Z 2025-08-14T11:45:41.7355791Z tests/test_splicing.py:528: ... 2025-08-14T11:45:41.7383073Z E pyln.client.lightning.RpcError: RPC call failed: method: waitsendpay, payload: {'payment_hash': '7b74fa9f6a889a16ebf89b8a9468302100f6ad50a771bbab2a16de58dcb1a9a4'}, error: {'code': 203, 'message': 'failed: WIRE_INCORRECT_OR_UNKNOWN_PAYMENT_DETAILS (reply from remote)', 'data': {'created_index': 1, 'id': 1, 'payment_hash': '7b74fa9f6a889a16ebf89b8a9468302100f6ad50a771bbab2a16de58dcb1a9a4', 'groupid': 1, 'destination': '035d2b1192dfba134e10e540875d366ebc8bc353d5aa766b80c090b39c3a5d885d', 'amount_msat': 10000000, 'amount_sent_msat': 10000101, 'created_at': 1755171392, 'status': 'pending', 'erring_index': 2, 'failcode': 16399, 'failcodename': 'WIRE_INCORRECT_OR_UNKNOWN_PAYMENT_DETAILS', 'erring_node': '035d2b1192dfba134e10e540875d366ebc8bc353d5aa766b80c090b39c3a5d885d', 'erring_channel': '103x2x0', 'erring_direction': 0, 'raw_message': '400f000000000098968000000072'}} ``` Caused by: ``` 2025-08-14T11:45:41.9275961Z lightningd-3 2025-08-14T11:36:32.700Z DEBUG 022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59-chan#1: Expiry cltv too soon 118 < 114 + 5 ``` Signed-off-by: Rusty Russell --- tests/test_splicing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_splicing.py b/tests/test_splicing.py index aed5061ce9a7..4974b91410af 100644 --- a/tests/test_splicing.py +++ b/tests/test_splicing.py @@ -506,7 +506,7 @@ def test_route_by_old_scid(node_factory, bitcoind): # Get pre-splice route. inv = l3.rpc.invoice(10000000, 'test_route_by_old_scid', 'test_route_by_old_scid') inv2 = l3.rpc.invoice(10000000, 'test_route_by_old_scid2', 'test_route_by_old_scid2') - route = l1.rpc.getroute(l3.info['id'], 10000000, 1)['route'] + route = l1.rpc.getroute(l3.info['id'], 10000000, 1, cltv=16)['route'] # Do a splice funds_result = l2.rpc.fundpsbt("109000sat", "slow", 166, excess_as_change=True)