Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export bitcoin's hash newtypes #38

Open
wants to merge 2 commits into
base: master
from

Conversation

@stevenroose
Copy link
Member

stevenroose commented Jan 10, 2020

They are semantically different, so we should provide them here.

I'm not 100% sure about this, though. Because they are still exchangeable, just "symlinks".

stevenroose added 2 commits Jan 10, 2020
@apoelstra

This comment has been minimized.

Copy link
Member

apoelstra commented Jan 10, 2020

It feels weird to me to just re-export. It will feel to the user that elements::BlockHash can be silently converted to a bitcoin::BlockHash even though these ought to be distinct types that cannot be interchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.