From af4b34ef4e1151a17036965f2664f208c452a8f9 Mon Sep 17 00:00:00 2001 From: jaimemcc Date: Fri, 28 Jun 2024 10:56:19 -0700 Subject: [PATCH 1/4] changing from self-hosted runners to Github's ubuntu-22.04 runner environment --- .github/workflows/cpu_ci.yml | 2 +- .github/workflows/cpu_ci_dispatch.yml | 2 +- .github/workflows/cpu_ci_on_pr.yml | 2 +- .github/workflows/pull_request.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/cpu_ci.yml b/.github/workflows/cpu_ci.yml index 9160fccab..6910b8a1c 100644 --- a/.github/workflows/cpu_ci.yml +++ b/.github/workflows/cpu_ci.yml @@ -5,7 +5,7 @@ on: "push" jobs: run-tests: #runs-on: ubuntu-latest - runs-on: [ 'test', 'self-hosted' ] + runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/cpu_ci_dispatch.yml b/.github/workflows/cpu_ci_dispatch.yml index b1d108b3b..38485d6a6 100644 --- a/.github/workflows/cpu_ci_dispatch.yml +++ b/.github/workflows/cpu_ci_dispatch.yml @@ -10,7 +10,7 @@ on: jobs: run-tests: - runs-on: [ 'test', 'self-hosted' ] + runs-on: ubuntu-22.04 steps: - name: Checkout Repository uses: actions/checkout@v4 diff --git a/.github/workflows/cpu_ci_on_pr.yml b/.github/workflows/cpu_ci_on_pr.yml index 971640c18..d5812fc93 100644 --- a/.github/workflows/cpu_ci_on_pr.yml +++ b/.github/workflows/cpu_ci_on_pr.yml @@ -7,7 +7,7 @@ on: jobs: run-tests: - runs-on: [ 'test', 'self-hosted' ] + runs-on: ubuntu-22.04 # ubuntu-latest currently points to ubuntu-22.04 but 24.04 is in beta - recommend testing on 24.04 and then changing instead of using ubuntu-latest steps: - name: Checkout Repository uses: actions/checkout@v4 diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 53be528ae..1a433e570 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -40,7 +40,7 @@ jobs: git commit -m "Update NeoXArgs docs automatically" git push run-tests: - runs-on: self-hosted + runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v2 - uses: actions/setup-python@v4 From 475f50a1e8b922743989e3445f76365714ba06b7 Mon Sep 17 00:00:00 2001 From: jaimemcc Date: Fri, 28 Jun 2024 10:59:51 -0700 Subject: [PATCH 2/4] adding warning about not using 'self-hosted' runner labels and using Github runners instead --- tests/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/README.md b/tests/README.md index 390a52898..f5ba5e560 100644 --- a/tests/README.md +++ b/tests/README.md @@ -57,6 +57,8 @@ Tests can be run against physical CPUs through GitHub Actions. To have tests run ### runs-on +#### NOTE: These BKMs were written to work with CI infrastructure that is no longer in place. To use the Github runners (ubuntu-22.04 / ubuntu-latest), skip the 'runs-on' section. + The CI needs to be written to target the CPU Github Action runner. The jobs that need to run on CPU should use the hardware runner's labels: ```yaml jobs: From 121ad99544bbf38b75cad41ff33d61ff5810774f Mon Sep 17 00:00:00 2001 From: jaimemcc Date: Fri, 28 Jun 2024 11:08:59 -0700 Subject: [PATCH 3/4] updated some guidance in comments for coverity scan CI --- .github/workflows/coverity_scan.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/coverity_scan.yml b/.github/workflows/coverity_scan.yml index a79d0d8fb..128d279cc 100644 --- a/.github/workflows/coverity_scan.yml +++ b/.github/workflows/coverity_scan.yml @@ -17,9 +17,10 @@ jobs: runs-on: ubuntu-latest env: - COV_USER: ${{ secrets.COV_USER }} + COV_USER: ${{ secrets.COV_USER }} # needs to be an email with access to the Coverity stream - add to secrets/actions COVERITY_PROJECT: ${{ secrets.COVERITY_PROJECT }} - COVERITY_TOKEN: ${{ secrets.COVERITY_TOKEN }} + COVERITY_TOKEN: ${{ secrets.COVERITY_TOKEN }} # you can get this token from Coverity stream dashboard: + # https://scan.coverity.com/projects/?tab=project_settings steps: - uses: actions/checkout@v2 From 12aea64b3f1ec0998886c25ec18c2fb32351eb1c Mon Sep 17 00:00:00 2001 From: jaimemcc Date: Fri, 28 Jun 2024 14:32:25 -0700 Subject: [PATCH 4/4] moving CPU tests to workflow_dispatch only --- .github/workflows/{cpu_ci_on_pr.yml => .cpu_ci_on_pr.yml} | 2 ++ .github/workflows/pull_request.yml | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) rename .github/workflows/{cpu_ci_on_pr.yml => .cpu_ci_on_pr.yml} (85%) diff --git a/.github/workflows/cpu_ci_on_pr.yml b/.github/workflows/.cpu_ci_on_pr.yml similarity index 85% rename from .github/workflows/cpu_ci_on_pr.yml rename to .github/workflows/.cpu_ci_on_pr.yml index d5812fc93..43ce025c0 100644 --- a/.github/workflows/cpu_ci_on_pr.yml +++ b/.github/workflows/.cpu_ci_on_pr.yml @@ -1,3 +1,5 @@ +# This file is hidden (.cpu_cpi_on_pr.yml) to minimize the number of runner minutes consumed. + name: "Pull Request CPU Tests" on: diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 1a433e570..7b06256bf 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -1,6 +1,7 @@ name: Pull Request -on: [pull_request, workflow_dispatch] +#on: [pull_request, workflow_dispatch] +on: workflow_dispatch jobs: pre-commit: