Permalink
Browse files

fix(river): floated river selector no longer breaks layout

River selector label is now wrapped in a clearfix ensuring layouts stay intact
when succeeding content is inline.
Also wraps label text into a span for proper vertical alignment.

Fixes #9091
  • Loading branch information...
hypeJunction committed Nov 2, 2015
1 parent e55edce commit 2745c91460915ae47519d79f70aa71736eda3449
Showing with 4 additions and 3 deletions.
  1. +2 −2 mod/aalborg_theme/views/default/elements/components.css
  2. +2 −1 views/default/core/river/filter.php
@@ -199,9 +199,9 @@
float: right;
margin: 13px 0 18px;
}
.elgg-river-selector select {
.elgg-river-selector * {
margin-left: 5px;
vertical-align: text-top;
vertical-align: middle;
}
.elgg-river-comments {
@@ -39,6 +39,7 @@
'class' => 'elgg-river-selector',
];
echo elgg_format_element('label', $attr, elgg_echo('filter') . " $select");
$input = elgg_format_element('label', $attr, elgg_format_element('span', [], elgg_echo('filter')) . " $select");
echo elgg_format_element('div', ['class' => 'clearfix'], $input);
elgg_load_js('elgg.ui.river');

0 comments on commit 2745c91

Please sign in to comment.