Permalink
Browse files

chore(ie): Remove all IE hacks

BREAKING CHANGE:
This removes several views related to IE. If you need support for browsers
not listed in our browser support policy, we encourage you to to do so with
feature detection and polyfills rather than conditional comments and user-agent
sniffing.
  • Loading branch information...
ewinslow committed May 26, 2015
1 parent 777d3b7 commit 7fe9329e648b82d1ffaa636d593a75b2f54f8c09
View
@@ -37,6 +37,17 @@ Basic instructions
Any modifications should have been written within plugins, so that they are not lost on overwriting.
If this is not the case, take care to maintain your modifications.
From 1.x to 2.0
===============
IE-specific workarounds have been dropped
-----------------------------------------
Several views (``css/ie``, ``css/ie7``, ``css/ie8``, etc.) as well as conditional
comments have been discarded now that IE10+ browsers are more standards-compliant.
If you need browser support farther back than that, you will need to find or build
a plugin that introduces its own compatibility layer or polyfills.
From 1.10 to 1.11
========================
View

This file was deleted.

Oops, something went wrong.
View

This file was deleted.

Oops, something went wrong.

This file was deleted.

Oops, something went wrong.

This file was deleted.

Oops, something went wrong.
@@ -30,21 +30,15 @@
echo elgg_format_element('link', $attributes);
}
$css = elgg_get_loaded_css();
$stylesheets = elgg_get_loaded_css();
$html5shiv_url = elgg_normalize_url('vendors/html5shiv.js');
$ie_url = elgg_get_simplecache_url('css', 'ie');
foreach ($css as $url) {
foreach ($stylesheets as $url) {
echo elgg_format_element('link', array('rel' => 'stylesheet', 'href' => $url));
}
// A non-empty script *must* come below the CSS links, otherwise Firefox will exhibit FOUC
// See https://github.com/Elgg/Elgg/issues/8328
?>
<!--[if gt IE 8]>
<link rel="stylesheet" href="<?php echo $ie_url; ?>" />
<![endif]-->
<script>
<?php // Do not convert this to a regular function declaration. It gets redefined later. ?>
require = function () {
@@ -53,7 +47,6 @@
};
_require_queue = [];
</script>
<!--[if lt IE 9]><script src="<?php echo $html5shiv_url; ?>"></script><![endif]-->
<?php
echo elgg_view_deprecated('page/elements/shortcut_icon', array(), "Use the 'head', 'page' plugin hook.", 1.9);

0 comments on commit 7fe9329

Please sign in to comment.