Permalink
Browse files

fix(a11y): aalborg mobile site menu uses the Font Awesome fa-bars icon

BREAKING CHANGE:
In aalborg_theme, the view `page/elements/navbar` now uses an icon for the
mobile menu selector (formerly an image). The `bars.png` image and supporting
CSS for the 1.12 rendering has been removed.

Fixes #9110
  • Loading branch information...
mrclay committed Dec 14, 2015
1 parent e160c1d commit a6a512e30f7298736566977f8d943d7f35be489e
@@ -408,6 +408,11 @@ The following views received ``label`` elements around some of the input fields.
- views/default/forms/admin/plugins/sort.php
- views/default/forms/login.php
+Plugin Aalborg Theme
+--------------------
+
+The view ``page/elements/navbar`` now uses a Font Awesome icon for the mobile menu selector instead of an image. The ``bars.png`` image and supporting CSS for the 1.12 rendering has been removed, so update your theme accordingly.
+
Plugin Likes
------------
Binary file not shown.
@@ -95,29 +95,17 @@
font-family: Arial, "Helvetica Neue", Helvetica, sans-serif;
color: #FFF;
float: left;
- padding: 14px 18px;
+ padding: 10px 18px;
}
.elgg-button-nav:hover {
color: #FFF;
text-decoration: none;
background-color: #60B8F7;
}
-/* .icon-bar elements had to be removed in 1.12.6 because they did not show up in Firefox/Android.
- * The .icon-bar CSS is deprecated and will be removed in 2.0
- */
-.elgg-button-nav .icon-bar {
- background-color: #F5F5F5;
- border-radius: 1px 1px 1px 1px;
- box-shadow: 0 1px 0 rgba(0, 0, 0, 0.25);
- display: block;
- height: 2px;
- width: 22px;
-}
-.elgg-button-nav .icon-bar + .icon-bar {
- margin-top: 3px;
-}
-.elgg-button-nav > img {
- display: block;
+.elgg-button-nav .elgg-icon-bars {
+ font-size: 18px;
+ color: #fff;
+ vertical-align: middle;
}
@media (max-width: 1030px) {
.elgg-menu-topbar-default > li:first-child a {
@@ -10,13 +10,7 @@
?>
<a class="elgg-button-nav" rel="toggle" data-toggle-selector=".elgg-nav-collapse" href="#">
- <?= elgg_format_element('img', [
- 'src' => elgg_get_site_url() . "mod/aalborg_theme/graphics/bars.png",
- 'width' => 22,
- 'height' => 12,
- 'alt' => elgg_echo('menu'),
- 'title' => '',
- ]) ?>
+ <?= elgg_view_icon('bars'); ?>
</a>
<div class="elgg-nav-collapse">

0 comments on commit a6a512e

Please sign in to comment.