New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popups open again after their trigger button/link is clicked to close the popup #10063

Closed
propertunist opened this Issue Aug 8, 2016 · 8 comments

Comments

Projects
None yet
2 participants
@propertunist

since v.2.2 i am seeing that the popup dialogs that open from the topbar - such as juho's notifier and also the 'add items menu' - are incorrectly opening after they have been opened and then closed again.

  1. click a button that triggers a popup to open.
  2. click the same button to then close the popup.
  3. the popup closes correctly but then opens again.

if i click on an area away from the popup or it's trigger button, then the popup correctly closes without reopening.

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Aug 9, 2016

Contributor

Can you reproduce on a vanilla install?
My guess is that you have a duplicate binding somewhere. Can you check all your JS files for rel="popup" bindings?

Contributor

hypeJunction commented Aug 9, 2016

Can you reproduce on a vanilla install?
My guess is that you have a duplicate binding somewhere. Can you check all your JS files for rel="popup" bindings?

@propertunist

This comment has been minimized.

Show comment
Hide comment
@propertunist

propertunist Aug 9, 2016

i have already tested with my theme disabled and with nothing else enabled that i know effects the popups. i just searched the whole elgg installation for rel=popup, rel="popup" and rel='popup' and nothing of relevance was found.. only instruction docs, core ui files and sandbox files were found.

propertunist commented Aug 9, 2016

i have already tested with my theme disabled and with nothing else enabled that i know effects the popups. i just searched the whole elgg installation for rel=popup, rel="popup" and rel='popup' and nothing of relevance was found.. only instruction docs, core ui files and sandbox files were found.

@propertunist

This comment has been minimized.

Show comment
Hide comment
@propertunist

propertunist Aug 9, 2016

i just updated my two plugins that use popups launched from the topbar.. so that they make use of the new method of configuring popups and use less JS. however, that didn't resolve the issue with the popup being triggered to open after it has been triggered to close.

i just updated my two plugins that use popups launched from the topbar.. so that they make use of the new method of configuring popups and use less JS. however, that didn't resolve the issue with the popup being triggered to open after it has been triggered to close.

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Aug 9, 2016

Contributor

I can't reproduce in Chrome. What browser are you using?

Contributor

hypeJunction commented Aug 9, 2016

I can't reproduce in Chrome. What browser are you using?

@propertunist

This comment has been minimized.

Show comment
Hide comment
@propertunist

propertunist Aug 9, 2016

ok, i am seeing the same behavior here with chromium 52 and firefox 48 on fedora 24.

ok, i am seeing the same behavior here with chromium 52 and firefox 48 on fedora 24.

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Aug 9, 2016

Contributor

Ok, I reread the issue and see the problem, though I am inclined to think it's an intended behavior.

Contributor

hypeJunction commented Aug 9, 2016

Ok, I reread the issue and see the problem, though I am inclined to think it's an intended behavior.

@propertunist

This comment has been minimized.

Show comment
Hide comment
@propertunist

propertunist Aug 9, 2016

in previous elgg versions, clicking the trigger buttons to close the popups did indeed just close them and not then reopen them. i'm not sure what benefit is offered by having a button that closes and then opens up a popup again. i feel this behavior is confusing and of no useful value to users. additionally this means that these buttons will change in behavior between versions without explanation.

in previous elgg versions, clicking the trigger buttons to close the popups did indeed just close them and not then reopen them. i'm not sure what benefit is offered by having a button that closes and then opens up a popup again. i feel this behavior is confusing and of no useful value to users. additionally this means that these buttons will change in behavior between versions without explanation.

@hypeJunction

This comment has been minimized.

Show comment
Hide comment
@hypeJunction

hypeJunction Aug 9, 2016

Contributor

Fix in #10067

Contributor

hypeJunction commented Aug 9, 2016

Fix in #10067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment