New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal sql error when loading plugins #10119

Closed
jdalsem opened this Issue Aug 25, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@jdalsem
Member

jdalsem commented Aug 25, 2016

There is an edge case where there are no suitable plugins to be loaded (i ran into this when disabling all plugins, other than a plugin with over 40 private settings)

https://github.com/Elgg/Elgg/blob/2.x/engine/classes/Elgg/BootData.php#L122

After removing all unsuitable plugins, there is the change no guids are left to load... it should quick return then...

This is an edge case, but easy to fix

@jdalsem jdalsem added the bug label Aug 25, 2016

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Aug 25, 2016

Member

Just curious, is the plugin with over 40 settings unusual? 40 is a completely arbitrary limit.

Member

mrclay commented Aug 25, 2016

Just curious, is the plugin with over 40 settings unusual? 40 is a completely arbitrary limit.

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Aug 25, 2016

Member

i do not know... i could check, but whatever the limit, the problem is still there

Member

jdalsem commented Aug 25, 2016

i do not know... i could check, but whatever the limit, the problem is still there

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Aug 26, 2016

fix(core): boot no longer fails if no plugins active
Also handles if the only active plugins have more than 40 private settings.

Fixes Elgg#10119
@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay
Member

mrclay commented Aug 26, 2016

PR #10123

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Aug 26, 2016

fix(core): boot no longer throws DB exception in some edge cases
If no plugin private settings were going to be preloaded, we no longer
run an invalid query.

Fixes Elgg#10119
@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Sep 6, 2016

Member

Fixed by #10123

Member

mrclay commented Sep 6, 2016

Fixed by #10123

@mrclay mrclay closed this Sep 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment