New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKeditor not always loaded (on Elgg community site at least) #10304

Closed
iionly opened this Issue Sep 28, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@iionly
Contributor

iionly commented Sep 28, 2016

Sometimes it works, sometimes it doesn't and then I only see a plaintext input field. Refreshing the page helps but this is not satisfying...

@jdalsem

This comment has been minimized.

Show comment
Hide comment
@jdalsem

jdalsem Sep 29, 2016

Member

any js errors? if it is reproducable could you see if the ckeditor js files are being loaded?

Member

jdalsem commented Sep 29, 2016

any js errors? if it is reproducable could you see if the ckeditor js files are being loaded?

@iionly

This comment has been minimized.

Show comment
Hide comment
@iionly

iionly Sep 29, 2016

Contributor

Problem is that it always surprised me so far and I can't reproduce it. If it happens again I hope to think of checking the browser console and maybe there's some error logged.

It might be a timeout issue as I have the impression that the community site is loading a bit slower than normal recently.

Contributor

iionly commented Sep 29, 2016

Problem is that it always surprised me so far and I can't reproduce it. If it happens again I hope to think of checking the browser console and maybe there's some error logged.

It might be a timeout issue as I have the impression that the community site is loading a bit slower than normal recently.

@iionly

This comment has been minimized.

Show comment
Hide comment
@iionly

iionly Sep 29, 2016

Contributor

The error message I found in the console is

"TypeError: c[a] is undefined in https://elgg.org/cache/1474508935/default/ckeditor.js:10:10495"

As the code is minified I don't know at which line the problem occurs exactly in the unminified code.

Contributor

iionly commented Sep 29, 2016

The error message I found in the console is

"TypeError: c[a] is undefined in https://elgg.org/cache/1474508935/default/ckeditor.js:10:10495"

As the code is minified I don't know at which line the problem occurs exactly in the unminified code.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Oct 1, 2016

Member

I think there's a race condition. Normally the editor requests these JS views:
ckeditor/config.js
ckeditor/lang/en.js

But sometimes these are requested, which result in 403 errors:
elgg/config.js
elgg/lang/en.js

Does this give us any ideas? cc @hypeJunction

Member

mrclay commented Oct 1, 2016

I think there's a race condition. Normally the editor requests these JS views:
ckeditor/config.js
ckeditor/lang/en.js

But sometimes these are requested, which result in 403 errors:
elgg/config.js
elgg/lang/en.js

Does this give us any ideas? cc @hypeJunction

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay

mrclay Oct 1, 2016

Member

When I uncomment the CKEDITOR_BASEPATH setting in elgg/ckeditor/set-basepath.js I get the same fail behavior, so I think this isn't being set early enough for some requests, even though this module is inlined in elgg.js.

Member

mrclay commented Oct 1, 2016

When I uncomment the CKEDITOR_BASEPATH setting in elgg/ckeditor/set-basepath.js I get the same fail behavior, so I think this isn't being set early enough for some requests, even though this module is inlined in elgg.js.

@mrclay

This comment has been minimized.

Show comment
Hide comment
@mrclay
Member

mrclay commented Oct 2, 2016

See #10337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment