Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group urls are invalid (Trac #1495) #1495

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 5 comments
Closed

group urls are invalid (Trac #1495) #1495

elgg-gitbot opened this issue Feb 16, 2013 · 5 comments
Labels
Milestone

Comments

@elgg-gitbot
Copy link

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Original ticket http://trac.elgg.org/ticket/1495 on 40105794-05-07 by cash, assigned to unknown.

Elgg version: Github Master

The ElggGroup get method returns group: when the object's username is requested. This is then used in urls. It is invalid to include a ':' in a url like this.

One effect of this is that it breaks get_submenu(). get_submenu() depends on php's parse_url which chokes on invalid urls. This means the selected menu item doesn't show up in group sidebar menus.

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

brettp wrote on 40369418-02-17

As a note, including group: in a URL does some rather annoying magic and sets the pageowner to the group. This is not documented well (anywhere?) and can make debugging complicated when trying to get the page owner.

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

brettp wrote on 40766495-11-11

Would

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Milestone changed to Elgg 1.9 by cash on 40888595-01-05

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

ewinslow wrote on 42623731-09-12

Looks like this is no longer an issue.

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Milestone changed to Elgg 1.8.0 by ewinslow on 42623731-09-12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant