Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
profile: Rewrite widget canvas to not use tables (Trac #1793) #1793
Original ticket http://trac.elgg.org/ticket/1793 on 39705620-05-27 by trac user coldtrick, assigned to cash.
Elgg version: 1.7
In IE7 if you have a long (lots of widgets) right column on your profile, the profile box table cell gets larger (which means a lot of white space).
In the css this is fixed for FF (and other browser) by providing a height=1px on this cell.
Unfortunately IE7 isn't listening to height=1px in strict mode. You can try this yourself on elgg.org.
I solved this by recoding the widgets layout to using div's instead of a table. Maybe in future version you could use div's instead of tables for the widget layout.
davetosh wrote on 39708311-12-26
The problem with using divs to layout the widget canvas instead of a table is it doesn't render correctly in IE6 (or at least we can't get things to render correctly in IE6). We would like to move to a div based layout but as long as Elgg needs to support IE6, we are stuck.
However, if someone comes up with a div based layout that does work well in IE6, we would certainly consider rolling with it.
trac user pete wrote on 39710921-12-06
Yeah, if I remember correctly the issue was with IE not adhering to table cells vertical-align:top; when the cell height is set to 100%.
To re-iterate what Dave said - if someone has the time and inkling to make a widget layout that works in IE6 as well as all the other browsers - we would definitely take a look and roll with it if it's robust.
trac user coldtrick wrote on 39713544-03-27
Ok guys, here it comes:
in canvas/layouts/widgets.php replace everything after line 254 (where the widgettable starts) with:
Then in the css add:
and in the css add to #widgets_left
and to #widgets_right
This should do the trick!
I personnaly confirmed it on a WindowsXP ie6 machine.
I did not provide the changes to the css that are now obsolete, but i guess you can figure that one out.