Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_objects_in_group fails when no objects of the requested subtype have been created (Trac #2358) #2358

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 2 comments
Labels
Milestone

Comments

@elgg-gitbot
Copy link

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Original ticket http://trac.elgg.org/ticket/2358 on 40537659-05-07 by trac user kevinjardine, assigned to unknown.

Elgg version: 1.7

I believe that this is because:

This is because line 491:

if ($subtype!=="") {

should be:

if ($subtype!== FALSE) {

(shouldn't this function be rewritten to use the new API in any case?)

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

brettp wrote on 40537770-07-17

(In [svn:6708]) Closes #2358, refs #2351. Using empty() to check for subtype string in get_objects_in_group().

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Milestone changed to Elgg 1.7.2 by cash on 40747616-12-13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant