Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add elgg_get_config() and elgg_set_config() for accessing $CONFIG global (Trac #2428) #2428

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 14 comments

Comments

@elgg-gitbot
Copy link

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Original ticket http://trac.elgg.org/ticket/2428 on 40653664-10-01 by cash, assigned to cash.

Elgg version: 1.8 Beta

  1. a common bug is forgetting to declare the global
  2. it leads to cleaner code
  3. people get scared off by this global variable when they don't need to be exposed to it. All plugin developers need it for is wwwroot, pluginpath, datapath and one or two other variables.
@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

brettp wrote on 40772215-06-06

Set at moderate difficulty because this will be tedious to address in core and its plugins.

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Title changed from start using get_config() rather than direct access of $CONFIG global to add elgg_get_config() and elgg_set_config() for accessing $CONFIG global by cash on 40831813-06-03

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

cash wrote on 40831814-08-05

Need to check into the difference between datalist and config tables for this.

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

ewinslow wrote on 40831840-05-22

I noticed that the config table has a site_guid parameter. Why aren't we just using metadata for this? Is there even a need for the config table at all?

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

cash wrote on 40831877-10-24

We have datalist for install specific settings, config for site specific settings, private settings on the site objects, and metadata on the site objects. A little redundancy?

Config is different from every other table in that all of its values are stored as serialized data. I don't know if that is even required.

Metadata is used to store the site email address and plugin information.

Private settings are not used.

Could it have been a bootstrapping related issue? Something preventing the site object from being loaded early in the boot sequence?

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

cash wrote on 40913215-02-19

(In [svn:7470]) Refs #2428 added elgg_get_config(), elgg_set_config(), and elgg_save_config()

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

cash wrote on 40914653-09-16

(In [svn:7476]) Refs #2428 adds elgg_get_plugin_path() and elgg_get_data_path()

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

cash wrote on 40914766-02-09

(In [svn:7479]) Refs #2428 removed some global CONFIG usage in plugins

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

cash wrote on 40914790-11-21

(In [svn:7480]) Refs #2428 removed a few CONFIG uses in core

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

cash wrote on 40997168-12-07

(In [svn:7769]) Refs #2428 removed more CONFIG uses

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

cash wrote on 41092812-07-08

(In [svn:7996]) Refs #2428 removed some uses of CONFIG in the views

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

cash wrote on 41092885-02-11

(In [svn:7999]) Refs #2428 almost done removing CONFIG access - mostly plugin start.php left

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

cash wrote on 41093861-07-29

(In [svn:8000]) Refs #2428 just a few more CONFIG uses left to be replaced

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

cash wrote on 41136638-03-04

(In [svn:8305]) Fixes #2428 last of the $CONFIG removals. Anything missed can be individual tickets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant