Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions/useradd.php still creates user before password check in 1.7.4 (Trac #2589) #2589

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 2 comments
Labels
Milestone

Comments

@elgg-gitbot
Copy link

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Original ticket http://trac.elgg.org/ticket/2589 on 40820417-10-08 by trac user obijohn, assigned to unknown.

Elgg version: 1.7

This error was corrected in actions/register.php but not in useradd.php. The lines are 28-30:

    $guid = register_user($username, $password, $name, $email, TRUE);

    if (((trim($password) != "") && (strcmp($password, $password2)==0)) && ($guid)) {

"register_user" is called before the two password entries are checked to see if they match and the test to see if the password is blank.

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Milestone changed to Elgg 1.7.5 by brettp on 40820448-11-20

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

cash wrote on 40821642-02-27

(In [svn:7120]) Fixes #2589 - user add action now checks password before creating user entity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant