Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messages: Add message threads (Trac #4287) #4287

Open
elgg-gitbot opened this issue Feb 16, 2013 · 14 comments
Open

messages: Add message threads (Trac #4287) #4287

elgg-gitbot opened this issue Feb 16, 2013 · 14 comments

Comments

@elgg-gitbot
Copy link

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Original ticket http://trac.elgg.org/ticket/4287 on 42027806-05-03 by trac user juho.jaakkola, assigned to unknown.

Elgg version: 1.7

When viewing a message from inbox, the original message is not attached to the reply like it is in sent messages.

This is because the receiver's copy of the message is missing "reply" relation to the original message.

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

brettp wrote on 42321949-09-24

juho.jaakkola - You assigned this to yourself--are you actively working on this?

Loading

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

trac user juho.jaakkola wrote on 42322543-05-10

I made a pull request 4 months ago but apparently it's still open.
#143

Loading

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

trac user juho.jaakkola wrote on 42323009-02-24

Actually it would be nice if the message page (messages/read/n) displayed a list of all the messages between two (or more?) users instead of just one message (with the original message as a possible attachment).

Then there wouldn't be need for the "reply" relation between the messages but instead the messages could be listed chronologically.

But I suppose a change as big as this isn't possible until Elgg 1.9?

Loading

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

ewinslow wrote on 42361030-11-07

I strongly agree with this suggestion.

Loading

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Milestone changed to Near Term Future Release by ewinslow on 42361030-11-07

Loading

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

cash wrote on 42472406-01-20

I tried to add displaying the original message above a reply in Elgg 1.8 and there was no good way to do this without ignoring access. I don't want to go down that route.

I was able to come up with a way to display message threads without too much difficulty so I'll schedule this for Elgg 1.9.

The idea is to assign a thread id through metadata to all messages. The thread id is inherited by replies. I can then display arbitrary numbers of messages backward (or forward) in time.

There will be some UI/retrieval issues to work out

Loading

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Milestone changed to Elgg 1.9.0 by cash on 42472406-01-20

Loading

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Title changed from Original message is not attached to the reply when viewing the reply. to Add message threads by cash on 42472406-01-20

Loading

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Milestone changed to Elgg 1.10.0 by cash on 43101167-07-15

Loading

@ewinslow
Copy link
Member

@ewinslow ewinslow commented Feb 5, 2015

Still agree this would be a great usability improvement to the current messages system... Big kudos for whoever takes on this hairy issue...

Loading

@hypeJunction
Copy link
Contributor

@hypeJunction hypeJunction commented Feb 5, 2015

Not an easy task. Did that in hypeInbox. Messages plugin needs some major
love.
On Feb 5, 2015 8:32 PM, "Evan Winslow" notifications@github.com wrote:

Still agree this would be a great usability improvement to the current
messages system... Big kudos for whoever takes on this hairy issue...


Reply to this email directly or view it on GitHub
#4287 (comment).

Loading

@beck24
Copy link
Member

@beck24 beck24 commented Feb 5, 2015

How about we just replace messages in 2.0 with something better designed?

Loading

@hypeJunction
Copy link
Contributor

@hypeJunction hypeJunction commented Feb 5, 2015

That would be optimal. Current implementation is a heavy mammoth
On Feb 5, 2015 10:03 PM, "Matt Beckett" notifications@github.com wrote:

How about we just replace messages in 2.0 with something better designed?


Reply to this email directly or view it on GitHub
#4287 (comment).

Loading

@ewinslow
Copy link
Member

@ewinslow ewinslow commented Feb 12, 2015

Yes please.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants