Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed: Embedding content should allow different link targets (Trac #4470) #4470

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 6 comments
Closed

Comments

@elgg-gitbot
Copy link

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Original ticket http://trac.elgg.org/ticket/4470 on 42322177-07-05 by trac user mrclay, assigned to unknown.

Elgg version: 1.8.3

We find some users using the embed content feature expect the link created to point to the file download instead of the description page. I can see users expecting both ways, which is why WordPress gives users the option to do either (or no link).

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 17, 2013

trac user mrclay wrote on 42482760-07-28

I think what would suffice is an intermediate step, after selecting the image, in which the user set embedding preference: size of the image (original being an option), the link URL (or none), alt/title text, and the align value. I don't think we need to get into captioning or duplicate WP's full image editing feature set.

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 17, 2013

cash wrote on 42482821-12-14

A 2 step process sounds like the right way to go.

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 17, 2013

Milestone changed to Elgg 1.8.13 by brettp on 43030284-04-11

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 17, 2013

Milestone changed to Elgg 1.8.14 by cash on 43074389-05-22

@ewinslow
Copy link
Contributor

@ewinslow ewinslow commented Mar 20, 2015

This hasn't gotten attention in years so is at risk of being closed for lack of interest. @mrclay do you have any new insights?

@jdalsem
Copy link
Member

@jdalsem jdalsem commented Jan 14, 2022

Not going to do anything about this in core at the moment. There is a plugin around that helps a bit with the issues mentioned in this ticket: https://github.com/coldtrick/embed_extended

@jdalsem jdalsem closed this Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants