Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_log(): Sniff the version and only use ip_address for latest version. (Trac #4487) #4487

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 7 comments
Labels
Milestone

Comments

@elgg-gitbot
Copy link

@elgg-gitbot elgg-gitbot commented Feb 16, 2013

Original ticket http://trac.elgg.org/ticket/4487 on 42334709-03-27 by brettp, assigned to unknown.

Elgg version: 1.8

Problematic upgrades if going from < 1.8.3 to 1.8.4.

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 17, 2013

brettp wrote on 42335398-12-08

Got to thinking, instead of a version sniff how does everyone feel if I add an internal var that will disable the sys log, and then we use that during upgrades? I don't think the syslog is particularly useful for upgrades.

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 17, 2013

brettp wrote on 42354939-10-19

Dupe of #4326. Now to figure out why it's not working correctly.

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 17, 2013

trac user Brett Profitt wrote on 42360450-08-18

Refs #4487. Turning off system log (even more) during upgrades. Removed debug call to system_log() in create_annotation().
Changeset: 25b1a1e

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 17, 2013

trac user captnbob wrote on 42381797-11-15

Brett, you asked for a Stack Trace on this problem. Here is mine with the exception being that this is a new install. I added a plugin and ran "upgrade.php" and got the same error:
Stack trace:
#0 /home/mysite/engine/lib/database.php(493): execute_query()
#1 /home/mysite/engine/lib/upgrades/2012012000-1.8.3-ip_in_syslog-87fe0f068cf62428.php(12): update_data()
#2 /home/mysite/engine/lib/upgrade.php(62): include('/home/mysite/...')
#3 /home/mysite/engine/lib/upgrade.php(255): upgrade_code()
#4 /home/mysite/upgrade.php(27): version_upgrade()
#5 {main}
[code:protected] => 0
[file:protected] => /home/mysite/engine/lib/database.php
[line:protected] => 261
[trace:private] => Array
(
[0] => Array
(
[file] => /home/mysite/engine/lib/database.php
[line] => 493
[function] => execute_query
)

[1] => Array
(
[file] => /home/mysite/engine/lib/upgrades/2012012000-1.8.3-ip_in_syslog-87fe0f068cf62428.php
[line] => 12
[function] => update_data
)

[2] => Array
(
[file] => /home/mysite/engine/lib/upgrade.php
[line] => 62
[args] => Array
(
[0] => /home/mysite/engine/lib/upgrades/2012012000-1.8.3-ip_in_syslog-87fe0f068cf62428.php
)

[function] => include
)

[3] => Array
(
[file] => /home/mysite/engine/lib/upgrade.php
[line] => 255
[function] => upgrade_code
)

[4] => Array
(
[file] => /home/mysite/upgrade.php
[line] => 27
[function] => version_upgrade
)

)

)

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 17, 2013

trac user Brett Profitt wrote on 42422641-04-20

Refs #4487. Turning off system log (even more) during upgrades. Removed debug call to system_log() in create_annotation().
Changeset: 25b1a1e

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 17, 2013

trac user Cash Costello wrote on 42464046-06-21

Fixes #4487 turned off logging for sites that haven't been upgraded with ip address column
Changeset: 242ea5f

@elgg-gitbot
Copy link
Author

@elgg-gitbot elgg-gitbot commented Feb 17, 2013

trac user Cash Costello wrote on 42466800-05-30

Fixes #4487 turned off logging for sites that haven't been upgraded with ip address column
Changeset: 242ea5f

adayth pushed a commit to adayth/Elgg that referenced this issue Feb 22, 2013
…emoved debug call to system_log() in create_annotation().
adayth pushed a commit to adayth/Elgg that referenced this issue Feb 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.