Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languages not being loaded during plugin activation. (Trac #4538) #4538

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 5 comments
Closed

Languages not being loaded during plugin activation. (Trac #4538) #4538

elgg-gitbot opened this issue Feb 16, 2013 · 5 comments

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/4538 on 42389660-06-14 by brettp, assigned to cash.

Elgg version: 1.8.5

Causes problems with writing default settings using activate.php. Probably due to changes in ElggPlugin.

@elgg-gitbot
Copy link
Author

cash wrote on 42422663-11-11

This causes problems if a plugin registers an admin message when enabled - see categories plugin

@elgg-gitbot
Copy link
Author

cash wrote on 42425293-09-04

Only happens when system cache is turned on. When the plugin calls register_translations(), that function tries to load the translations from the cache and it cannot tell that it does not exist.

register_translations() is too complicated.

@elgg-gitbot
Copy link
Author

cash wrote on 42446668-08-03

I think I have a solution for this now. It requires rewriting the caching code so that all languages are cached the first time after the system cache has been flushed rather than loading them as needed and then caching. This will allow us to not even call register_translations() from the plugin init method when the system cache is turned on (similar to view caching).

@elgg-gitbot
Copy link
Author

trac user Cash Costello wrote on 42464213-02-02

Merge pull request #274 from cash/language_caching

Fixes #4538 Language caching rewrite
Changeset: 9f5634b

@elgg-gitbot
Copy link
Author

trac user Cash Costello wrote on 42466800-06-11

Merge pull request #274 from cash/language_caching

Fixes #4538 Language caching rewrite
Changeset: 9f5634b

adayth pushed a commit to adayth/Elgg that referenced this issue Feb 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant