Skip to content

/Elgg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade type hint violations to warnings (Trac #4619) #4619

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 3 comments

Comments

@elgg-gitbot
Copy link

commented Feb 16, 2013

Original ticket http://trac.elgg.org/ticket/4619 on 42477031-06-21 by trac user mrclay, assigned to unknown.

Elgg version: 1.8.6

Fixing #4447 caused type hint violations to fatal error (default PHP behavior), unfortunately Elgg has suppressed this before 1.8.6 and there are violations occurring in real-world sites that were not noticed during testing.

Cash suggested that we should downgrade these to emit warnings.

@elgg-gitbot elgg-gitbot closed this Feb 16, 2013

@elgg-gitbot elgg-gitbot referenced this issue Feb 16, 2013
Closed
@elgg-gitbot

This comment has been minimized.

Sign in to view
Copy link
Author

commented Feb 17, 2013

Milestone changed to Elgg 1.8.7 by cash on 42479340-07-13
@elgg-gitbot

This comment has been minimized.

Sign in to view
Copy link
Author

commented Feb 17, 2013

trac user Cash Costello wrote on 42479375-09-27

Fixes #4619 downgraded type violations to warnings
Changeset: ffd992a
@elgg-gitbot

This comment has been minimized.

Sign in to view
Copy link
Author

commented Feb 17, 2013

trac user Cash Costello wrote on 42479447-07-08

Fixes #4619 downgraded type violations to warnings
Changeset: ffd992a

adayth pushed a commit to adayth/Elgg that referenced this issue Feb 22, 2013

@cash
Fixes Elgg#4619 downgraded type violations to warnings
ffd992a
@Srokap Srokap referenced this issue Feb 16, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine feature important
Projects
None yet
Milestone
  Elgg 1.8.7
1 participant
@elgg-gitbot
You can’t perform that action at this time.