Skip to content
This repository

Fix HTML5 validation errors (Trac #4801) #4801

Closed
elgg-gitbot opened this Issue · 16 comments

6 participants

elgg-gitbot Sem Cash Costello Paweł Sroka Evan Winslow Steve Clay
elgg-gitbot
Owner

Original ticket http://trac.elgg.org/ticket/4801 on 42619549-05-21 by ewinslow, assigned to unknown.

  • <acronym>
  • Using size on <input type=file>
  • rel for foaf link
  • rel for confirm text

Not fixing in 1.9:

  • use of rel for toggle and popup
Sem
Collaborator

What is size on ?

Sem
Collaborator

And what about <link rel="meta" type="application/rdf+xml" title="FOAF" href="http://elgg.dev/activity?view=foaf" />? It isn't validating.

Cash Costello
Owner

Does it validate if you change "meta" to "alternate"?

Cash Costello
Owner

@sembrestels Regarding size, I think input/file specifies a default size. You can test by validating the file upload page.

Cash Costello
Owner
cash commented

@ewinslow I couldn't find any duplicate form IDs. I only found 2 instances of form IDs in Elgg - the group invitation form and the messages reply form.

Sem
Collaborator

@cash, Why don't we use <time> instead <abbr> in substitution of <acronym>?

You have an approach here.

Paweł Sroka
Owner
Srokap commented

Refs: #4273, #3284,

Cash Costello
Owner
cash commented

http://caniuse.com/#search=time
IE8 does not support <time>

Sem
Collaborator

Ok, I undersand. We can use html5shiv yet, but I understand this is messy and can cause problems.

Evan Winslow
Owner

Html5shim is a fine solution, I think, to the time issue.

Cash Costello
Owner
cash commented

Not worth it to add all that for just switching from abbr to time. Shims often have side effects and add bloat. If this was a really essential feature, I could see trying out html5shiv.

Evan Winslow
Owner

I find these reasons less than compelling. It's a tiny well tested library that is only needed for ie8.

Cash Costello
Owner
cash commented

I don't find including a library just to switch from <abbr> to <time> compelling - especially since we're talking about radically changing how we handle friendly time in the next version of Elgg.

Sem
Collaborator

@cash, I see your insistence and I won't be more boring. Just say that if we want maintain compatibility with IE8, we should include html5shiv anyway.

As <time>, IE8 doesn't support <section>, <article>, <aside>, <hgroup>, <header>, <footer>, <nav>... and community plugins will use them, breaking the compatibility. For this reason, I'd like see html5shiv included in Elgg 1.9.

Steve Clay
Owner
mrclay commented

Moving html5shim discussion to #5492.

Cash Costello cash closed this
Cash Costello
Owner
cash commented

I could not find any form id duplicates so closing this. Please open a new ticket for additional validation fixes.

Sem sembrestels referenced this issue from a commit in sembrestels/Elgg
Sem sembrestels Refs #4801. Upgraded search box view to html5. 948caa9
Sem sembrestels referenced this issue from a commit in sembrestels/Elgg
Sem sembrestels Refs #4801. Removed timestamp class. 6909a62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.