Skip to content

Fix HTML5 validation errors (Trac #4801) #4801

Closed
elgg-gitbot opened this Issue Feb 16, 2013 · 16 comments

6 participants

@elgg-gitbot

Original ticket http://trac.elgg.org/ticket/4801 on 42619549-05-21 by ewinslow, assigned to unknown.

  • <acronym>
  • Using size on <input type=file>
  • rel for foaf link
  • rel for confirm text

Not fixing in 1.9:

  • use of rel for toggle and popup
@elgg-gitbot elgg-gitbot reopened this Feb 17, 2013
@sembrestels sembrestels added a commit to sembrestels/Elgg that referenced this issue Feb 21, 2013
@sembrestels sembrestels Refs #4801. Deprecated rel=popup and rel=toggle. 6cf457f
@sembrestels
Elgg member

What is size on ?

@sembrestels
Elgg member

And what about <link rel="meta" type="application/rdf+xml" title="FOAF" href="http://elgg.dev/activity?view=foaf" />? It isn't validating.

@cash
cash commented Feb 21, 2013

Does it validate if you change "meta" to "alternate"?

@sembrestels sembrestels was assigned Feb 22, 2013
@cash
cash commented Feb 22, 2013

@sembrestels Regarding size, I think input/file specifies a default size. You can test by validating the file upload page.

@cash cash added a commit that referenced this issue May 8, 2013
@cash cash Refs #4801 not passing size for file inputs e85d6c2
@cash
cash commented May 8, 2013

@ewinslow I couldn't find any duplicate form IDs. I only found 2 instances of form IDs in Elgg - the group invitation form and the messages reply form.

@sembrestels
Elgg member

@cash, Why don't we use <time> instead <abbr> in substitution of <acronym>?

You have an approach here.

@Srokap
Srokap commented May 11, 2013

Refs: #4273, #3284,

@cash
cash commented May 11, 2013

http://caniuse.com/#search=time
IE8 does not support <time>

@sembrestels
Elgg member

Ok, I undersand. We can use html5shiv yet, but I understand this is messy and can cause problems.

@ewinslow
Elgg member

Html5shim is a fine solution, I think, to the time issue.

@cash
cash commented May 11, 2013

Not worth it to add all that for just switching from abbr to time. Shims often have side effects and add bloat. If this was a really essential feature, I could see trying out html5shiv.

@ewinslow
Elgg member

I find these reasons less than compelling. It's a tiny well tested library that is only needed for ie8.

@cash
cash commented May 11, 2013

I don't find including a library just to switch from <abbr> to <time> compelling - especially since we're talking about radically changing how we handle friendly time in the next version of Elgg.

@sembrestels
Elgg member

@cash, I see your insistence and I won't be more boring. Just say that if we want maintain compatibility with IE8, we should include html5shiv anyway.

As <time>, IE8 doesn't support <section>, <article>, <aside>, <hgroup>, <header>, <footer>, <nav>... and community plugins will use them, breaking the compatibility. For this reason, I'd like see html5shiv included in Elgg 1.9.

@mrclay
Elgg member
mrclay commented May 17, 2013

Moving html5shim discussion to #5492.

@cash
cash commented May 17, 2013

I could not find any form id duplicates so closing this. Please open a new ticket for additional validation fixes.

@cash cash closed this May 17, 2013
@sembrestels sembrestels added a commit to sembrestels/Elgg that referenced this issue Jun 8, 2013
@sembrestels sembrestels Refs #4801. Upgraded search box view to html5. 948caa9
@sembrestels sembrestels added a commit to sembrestels/Elgg that referenced this issue Jun 8, 2013
@sembrestels sembrestels Refs #4801. Using time tag in friendly time view. fe3871a
@sembrestels sembrestels added a commit to sembrestels/Elgg that referenced this issue Jun 9, 2013
@sembrestels sembrestels Refs #4801. Removed timestamp class. 6909a62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.